Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cryptography and pyOpenSSL (security) #6055

Merged
merged 13 commits into from
Nov 3, 2023
Merged

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Nov 2, 2023

@arm4b arm4b added this to the 3.8.1 milestone Nov 2, 2023
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Nov 2, 2023
Fixes warning in paramiko about deprecated `Blowfish` algo since cryptography 37.0.0 that fails st2 integration tests.
See: https://www.paramiko.org/changelog.html#2.10.5
```
/opt/**********/st2/lib/python3.6/site-packages/st2client/shell.py:27: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography. The next release of cryptography (40.0) will be the last to support Python 3.6.
  from cryptography.utils import CryptographyDeprecationWarning
```
in CLI and failing py3.6 unit tests
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Nov 2, 2023
```
/opt/**********/st2/lib/python3.6/site-packages/st2client/shell.py:27: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography. The next release of cryptography (40.0) will be the last to support Python 3.6.
  from cryptography.utils import CryptographyDeprecationWarning
```
in CLI and failing py3.6 unit tests
```
/opt/**********/st2/lib/python3.6/site-packages/st2client/shell.py:27: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography. The next release of cryptography (40.0) will be the last to support Python 3.6.
  from cryptography.utils import CryptographyDeprecationWarning
```
in CLI and failing py3.6 tests
@arm4b arm4b changed the title Update cryptography and pyOpenSSL Update cryptography and pyOpenSSL (security) Nov 3, 2023
@arm4b arm4b marked this pull request as ready for review November 3, 2023 14:50
@arm4b
Copy link
Member Author

arm4b commented Nov 3, 2023

Yay, RFR!
That was quite a rabbit hole 🐰

@arm4b arm4b requested a review from a team November 3, 2023 14:50
@arm4b arm4b enabled auto-merge November 3, 2023 14:51
@arm4b arm4b merged commit c8008e8 into master Nov 3, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement external dependency security size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants