Skip to content

Fix GUI limit issue for "Packs" and "Triggers" (cf. st2web issue #1034). #6360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimothyDJones wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix GUI limit issue for "Packs" and "Triggers" (cf. st2web issue #1034). #6360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4351e8
Update sensor wrapper to make `list_values()` method congruent with r…
TimothyDJones Feb 24, 2023
7c79e5e
Add change log comment for PR #5913.
TimothyDJones Feb 24, 2023
82297ec
Increase default for `limit` parameter to 500.
TimothyDJones Oct 31, 2025
e503ca5
Merge branch 'master' into fix_gui_limit_issue
TimothyDJones Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@ Fixed

Added
~~~~~
* Add support for `limit` and `offset` parameters in sensor wrapper `list_items()`
method to make congruent with regular datastore method. #5913

* Move `git clone` to `user_home/.st2packs` #5845

* Error on `st2ctl status` when running in Kubernetes. #5851
Expand Down
4 changes: 2 additions & 2 deletions st2common/st2common/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1753,7 +1753,7 @@ paths:
in: query
description: Number of packs to get
type: integer
default: 100
default: 500
- name: offset
in: query
description: Number of packs to offset
Expand Down Expand Up @@ -3870,7 +3870,7 @@ paths:
in: query
description: Number of trigger types to get
type: integer
default: 100
default: 500
- name: offset
in: query
description: Number of trigger types to offset
Expand Down
4 changes: 2 additions & 2 deletions st2common/st2common/openapi.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1749,7 +1749,7 @@ paths:
in: query
description: Number of packs to get
type: integer
default: 100
default: 500
- name: offset
in: query
description: Number of packs to offset
Expand Down Expand Up @@ -3866,7 +3866,7 @@ paths:
in: query
description: Number of trigger types to get
type: integer
default: 100
default: 500
- name: offset
in: query
description: Number of trigger types to offset
Expand Down
2 changes: 1 addition & 1 deletion st2reactor/st2reactor/container/sensor_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def dispatch_with_context(self, trigger, payload=None, trace_context=None):
# Methods for datastore management
##################################

def list_values(self, local=True, prefix=None, limit=None, offset=None):
def list_values(self, local=True, prefix=None, limit=None, offset=0):
Copy link
Contributor

@fdrab fdrab Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for datastore items. what are you trying to do here?

return self.datastore_service.list_values(
local=local, prefix=prefix, limit=limit, offset=offset
)
Expand Down
Loading