Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: EL8 rpm package #135

Closed
wants to merge 5 commits into from
Closed

WIP: EL8 rpm package #135

wants to merge 5 commits into from

Conversation

punkrokk
Copy link
Member

@punkrokk punkrokk commented Jan 9, 2020

  • Added support for EL8
  • Works fine, locally, but there are a bunch of node security issues.
  • most build are broken, not sure if this was the deal already, I can build locally fine.
  • lots broken in circle.
npm install --production
npm WARN babel-eslint@10.0.2 requires a peer of eslint@>= 4.12.1 but none is installed. You must install peer dependencies yourself.
npm WARN hubot-botframework@0.10.1 requires a peer of hubot@^2.19.0 but none is installed. You must install peer dependencies yourself.

audited 6575 packages in 8.185s
found 228 vulnerabilities (2 low, 56 moderate, 168 high, 2 critical)
  run `npm audit fix` to fix them, or `npm audit` for details
npm cache verify && npm cache clean --force

cc @armab

@punkrokk
Copy link
Member Author

punkrokk commented Jan 9, 2020

#104 cc @blag

@arm4b
Copy link
Member

arm4b commented Jan 10, 2020

I've restarted previously successful builds and they're are broken as well.
Might be some upstream dependency change during the build process that rolled out between now and latest build time.

@blag blag mentioned this pull request Jan 11, 2020
@punkrokk
Copy link
Member Author

@armab @blag What I can say is EL8 builds on my mac. I'll see what I can figure out this week. The node stuff is a bit out of my wheelhouse these days.

@blag
Copy link
Contributor

blag commented Jan 12, 2020

@punkrokk Can you (on your local machine) rebase these changes on #136 and see if it still builds on your machine? CircleCI has been bugging out for that PR this weekend.

@punkrokk
Copy link
Member Author

@blag Still able to build on my mac but not in circle. See the logs in circle. Its something to do with the npm version and the root user the containers use.

@punkrokk punkrokk closed this Jan 17, 2020
@blag blag added the OS support Support/issues/PRs on a specific OS label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature OS support Support/issues/PRs on a specific OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants