Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build, pin lerna version #1008

Merged
merged 19 commits into from
Oct 19, 2023
Merged

Fix build, pin lerna version #1008

merged 19 commits into from
Oct 19, 2023

Conversation

guzzijones
Copy link
Contributor

fix the lerna version so the build continues

@guzzijones
Copy link
Contributor Author

looks like docker needs a restart on that circleci vm ?

@enykeev
Copy link
Member

enykeev commented Oct 13, 2023

@guzzijones we've seen similar problems in other projects relying on docker registry and so far the only thing that had any effect is to try and restart the job some time later. Two weeks should be plenty enough for any kind of networking issues to resolve. There's plenty of other suggestions on the internet to try logging out of docker and logging back in, but they sound awfully like just trying all the options under the sun.

Do you want to try and restart this job again to see if anything has changed?

@arm4b
Copy link
Member

arm4b commented Oct 18, 2023

Thanks @enykeev and good to see you already helping! 👍

I just pushed a dummy commit to @guzzijones fork to rebuild it (CircleCI seems to not allow GH-based login anymore) and it failed in a later step: https://app.circleci.com/pipelines/github/StackStorm/st2web/3867/workflows/b15c3ceb-1ca1-4d6c-9fd7-8b678b2584d8/jobs/6170?invite=true#step-119-1823_20

Looks like lerna should be pinned in more places:

npm install -g lerna

@guzzijones can you update it, or perhaps @enykeev want to try in a brand new PR? We'll need more involved dependency updates anyway for st2web.

@arm4b arm4b added this to the 3.8.1 milestone Oct 18, 2023
@enykeev
Copy link
Member

enykeev commented Oct 19, 2023

@armab I'll try to have a look on the weekend and see if if I can figure out what's wrong. That is if your efforts will not succeed. I will however need you to add me to maintainers so I can rerun CI runs at will.

@arm4b arm4b added the bug label Oct 19, 2023
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guzzijones for the fix and @enykeev for bumping this.

@arm4b arm4b merged commit e409aaa into StackStorm:master Oct 19, 2023
2 checks passed
@arm4b
Copy link
Member

arm4b commented Oct 19, 2023

@enykeev I had to push some dummy commits to @guzzijones fork as CircleCI re-build and access rights are terribly broken (I got 404s, 403s and 50Xs myself even for the CircleCI builds in the org https://github.com/StackStorm/st2web/assets/1533818/25fc89c0-cb53-4d46-bb50-c7055caf92ad). If you could work on your fork, - the builds could be restarted OK.

The real work, - we'll need an overall renovation, audit and updating the dependencies + nodejs and whatnot for st2web (example, see: https://github.com/StackStorm/st2web/pulls/app%2Fdependabot) and st2chatops (more severe). I'll ask for temporary access rights from the TSC for this work if we'll hit a permissions roadblock.
@enykeev Could you please join us in Slack (#tsc channel in https://stackstorm.com/#community)?

@arm4b arm4b changed the title fix lerna version Fix build, pin lerna version Oct 19, 2023
arm4b added a commit that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants