-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add st2chatops #17
Comments
As per documentation, st2chatops can work in HA as a shared component. Trying to the best way to accomplish that, How valid is following a scenario?
Any feedback on the feasibility of this approach and/or whether this can be considered as a viable chatops addition to Stackstorm HA. If we have a positive answer for the above, the next stop is how we can automate this flow using the existing chart to include chatops as well. |
https://github.com/afoninsky/stackstorm-chatops-playground I played with implementing chatops into existing stackstorm kubernetes instance with additional telegram adapter. |
@mosn See:
What we want to do is just having 1 normally installed instance of |
As for implementation, ideally to start with defining a Dockerfile for st2chatops here: https://github.com/stackstorm/st2-dockerfiles so we can proceed with deploying it to Docker Hub (https://hub.docker.com/u/stackstorm). st2chatops configuration could be controlled by passing ENV variables to override defaults from https://github.com/StackStorm/st2chatops/blob/master/st2chatops.env. Once that's done next step would be creating a K8s resource for st2chatops as well as corresponding Helm values for We're definitely very open to contributions and happy if someone can work on that before we'll reach this task ourselves 👍 We'll provide feedback & help along the way. |
My approach so far and possibly calls for comments:
My next step:
Things I still haven't figured out:
|
@mosn I think docker-in-docker and building Ideally is to build and deploy produced st2chatops image to some Docker repository and refer to it in K8s deployment. Passing Hubot adapter & settings via ENV variables like it happens https://github.com/StackStorm/st2chatops/blob/master/st2chatops.env should be good enough. At this point if you want, you can contribute your |
@armab Thanks for the info. I will publish my changes as soon as I have it in good shape. I hope the community finds useful. |
@mosn Got it. |
I faced following questions while working on this
|
@mosn Sure, as you already created a Github fork with custom changes, just fill a "Work in Progress" Pull Request against our |
@armab I'd like to take a few moments to reflect on our current progress. st2-dockerfiles # 19 Is anyone interested? you are more than welcome to join. If you have questions about the current stage, I'd be happy to answer any questions. |
@mosn Based on latest commits, that's a good progress towards official We can return anytime to it as you wish and there is no rush. Someone else could fork it and work further or just provide comments/ideas. Additionally, with time we, per our plans can finally hit this task and commit directly to your branch/fork. The bootstrap you did in that PR is already very helpful. Overall I think it's all good work and valuable, thank you for doing this 👍 |
The biggest unknown for me how to implement the executable in the dockerfile in such a way that it works. Cannot get /bin/hubot/ to work due to not incorrect or missing PATH. Following is where I stand currently. (Will update repository later today)
- installing st2chatops was independent docker container without dependency to st2chatops.env
- deploying stackstorm charts with the st2chaops container on top.
- this is where chatops pod keeps crashing because of not finding the exec command.
I discussed this matter with the community and we concluded staying with the original plan is the right approach. If that’s the case It would be great if we can find support on following
1. In light of the new setup where the st2chatops.env is no longer needed to exists in the docker container, how should the implementation progress?
2. Given that we do not want to have a separate entry point for the st2chatops, what is the best approach towards container initialization?
3. on the helm side of things are their dependencies for st2chatops that we must know of.
…Sent from my iPhone
On 28. Mar 2019, at 17:42, Eugen C. ***@***.***> wrote:
@mosn Based on latest commits, that's good progress towards official st2chatops implementation in K8s/Helm.
We can return anytime to it as you wish and there is no rush. Someone else could fork it and work further or just provide comments/ideas. Additionally, with time we, per our plans can finally hit this task and commit directly to your branch/fork. The bootstrap you did in that PR is already very helpful.
Overall I think it's all good work and valuable, thank you for doing this 👍
We can collectively move that into a good state earlier or later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Absolutely! I'll try to open source as much as I can on our implementation but I am experimenting with Terraform to see if that can make it bit uncluttered for us. |
Currently K8s/Helm is missing st2chatops deployment.
Making it Docker and K8s-friendly to read ENV vars outside of
st2chatops.env
will take some work, (see blocker StackStorm/st2chatops#50).And so running 1 replica of st2chatops would be doable and nice to have, but having st2chatops in
HA
is a story for a new dedicated issue and research.The text was updated successfully, but these errors were encountered: