Chatops integration #55

rapittdev · 2019-03-15T15:48:36Z

Closes #17

Proposal for chatops integration base on #17

As mentioned in the tracking issue:

Update st2docs
start with defining a Dockerfile for st2chatops
st2chatops configuration could be controlled by passing ENV variables to override defaults
creating a K8s resource for st2chatops as well as corresponding Helm values

find out more about the why here

ghost · 2019-03-15T16:19:40Z

Thank you @armab for the suggestions. I ended up doing that after tested the other approaches. as suggested, This is a base for discussions/suggestions.

I took this repository as a stepping stone for the new integration, There aren't much of diversion from it; However, there might be unnecessary values passed around which is left for cleaning up.

Corresponding st2-dockerfile PR In my approach I am using st2chatops package. TBD if there's a better source.

I probably need a few more days to bring it to a clean state, feedback, contributions very welcome as I won't be able to commit time next week.

If there's a better/alternative approach, feel free to close this PR.

arm4b

Can you please sync-up your branch with the upstream master, so we'll see only the diff from this specific change?

ghost · 2019-03-19T19:13:14Z

Hey Sure, This branch is outdated as I worked on it locally. Will push changes later today. Thanks

…

On Mar 19, 2019, at 8:12 PM, Eugen C. ***@***.***> wrote: @armab requested changes on this pull request. Can you please sync-up your branch with the upstream master, so we'll see only the diff from this specific change? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#55 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE_WySOXcphnXbPpGdU3hKtUqL2_3-Vhks5vYTaCgaJpZM4b2w-r>.

arm4b

Thanks for the contribution! 👍

I provided some first early comments that'll help to course correct and move forward future st2chatops support in ST2 K8s/Helm.

values.yaml

chatops-settings.yaml

values.yaml

templates/deployments.yaml

arm4b

At a high level, I see it as the following way to configure chatops via Helm values.yaml

[....]

# StackStorm ChatOps (https://docs.stackstorm.com/chatops/index.html)
# As hubot can't be HA scaled properly, we deploy only single replica of st2chatops
st2chatops:
  # Enable st2chatops (default: false)
  enabled: true
  # Custom hubot adapter ENV variables to pass through which will override st2chatops.env defaults.
  # See https://github.com/StackStorm/st2chatops/blob/master/st2chatops.env
  # for the full list of supported adapters and example ENV variables.
  env:
    HUBOT_ADAPTER: slack
    HUBOT_SLACK_TOKEN: xoxb-CHANGE-ME-PLEASE
  # Use custom generated st2chatops Docker image 
  image:
  #  repository: stackstorm
  #  name: st2chatops
  #  tag: {{ .Chart.AppVersion }}
  #  pullPolicy: Always
  resources: {}
  # Additional advanced settings to control pod/deployment placement
  nodeSelector: {}
  tolerations: []
affinity: {}

Meaning we'll pass additional/custom ENV variables to st2chatops container that will be applied on top of defaults. This brings flexibility of configuring any existing or future added new adapters like StackStorm/st2chatops#121

arm4b · 2019-03-25T13:41:10Z

Looks like the fork/branch still needs to be synced with upstream properly as Github diff shows unrelated to this PR changes https://github.com/StackStorm/stackstorm-ha/pull/55/files

rapittdev · 2019-03-27T20:59:53Z

Since I'm try

Looks like the fork/branch still needs to be synced with upstream properly as Github diff shows unrelated to this PR changes https://github.com/StackStorm/stackstorm-ha/pull/55/files

Might it happen because I have local branch set to something other than master ?
I tried...

git pull upstream

git remote -v shows

origin	https://github.com/rapittdev/stackstorm-ha.git (fetch)
origin	https://github.com/rapittdev/stackstorm-ha.git (push)
upstream	https://github.com/StackStorm/stackstorm-ha.git (fetch)
upstream	https://github.com/StackStorm/stackstorm-ha.git (push)

ghost · 2019-03-27T22:01:24Z

@armab I think we're better off closing this PR when all the details are cleared and submit a new one with proper implementation. If you agree I'll get started with that. This was just an early setup to better get a grasp of what we're dealing with. I have to force push my changes in order to be able to sync with upstream again. Sorry about that.

rapittdev · 2019-04-05T12:13:40Z

@armab @warrenvw I tried syncing with upstream and after some-time wrestling, I think this is best I got. I am not sure if that's updated since I see merging blocks. But I have an idea. If you agree you can open a new branch for chops so the community can directly contribute to. I think that'll save us time.

I also was able to deploy to k8 while pulling the image of the st2-docker file. I added some cleanups on my code which I will cherry peak into the new branch.

** Sorry about any type while mobile, I'll fix it later**

arm4b · 2019-04-05T12:25:36Z

@rapittdev As I see, the github diff still shows old content that was already contributed to upstream master branch. We can't open an all-writeable branch for community per Github limitations.
But if you want to open a new PR instead of this one, - that would be fine too.

rapittdev

Thank you. With help from the StackStrom community, we were able to deploy to k8. This is still a wimp since we're waiting for feedback on how to proceed.

Chart.yaml

README.md

chatops-settings.yaml

templates/configmaps_chatops.yaml

templates/deployments.yaml

… into chatops-ha

…t placement

rapittdev · 2019-04-12T20:04:37Z

👍👍👍 Thanks @armab @warrenvw This chart was already ahead, now it's about to get wings! Thank you for helping us finalize this. We're planning to launch our product with Stackstorm-Ha!

arm4b · 2019-04-12T20:43:27Z

@mosn Thank you for starting this K8s Chatops work, making changes and bringing this feature to a working state! Appreciate your contribution 👍

Just added a little bit of polishing here and there and tried to find possible corner cases. One of them is reported in StackStorm/st2chatops#124
@warrenvw I'll wait for your additional review in this PR and @mosn if you can double-check 👀 and verify this PR in action too, - that would help before we merge it early next week.

ghost · 2019-04-13T10:13:40Z

@armab I'll be able to start the integration at 15:00 CET. I will provide updates as I progress through the implementation.

ghost · 2019-04-13T22:44:15Z

Cluster is ready based on following best practice

https://github.com/bitnami/kube-prod-runtime/blob/master/docs/quickstart-gke.md

Going to start with Stackstorm and chatops now

warrenvw

LGTM! Well done. 👍

The code is easy to understand.

ghost · 2019-04-16T07:42:01Z

it works great too!

@armab I had to move to EWC 3.0 because of this. So far the improved workflow was able to do 5 hours job in 30min. Very helpful with a syntax error. As for chatops I'll finish converting all my mistral chains and then look at that, hopefully, I can work out detailed feedback later in this week.

Just quick info, the description for this chart is an accurate description of my experience.

Based on StackStorm/stackstorm-k8s#55

mosn added 2 commits March 15, 2019 16:45

base

089504c

missing commits found

eb859ae

ghost mentioned this pull request Mar 15, 2019

StackStorm chatops container integration StackStorm/st2-dockerfiles#19

Merged

arm4b suggested changes Mar 19, 2019

View reviewed changes

arm4b added feature WIP labels Mar 19, 2019

sync upstream

ba0d016

arm4b suggested changes Mar 25, 2019

View reviewed changes

ghost mentioned this pull request Mar 26, 2019

Add st2chatops #17

Closed

rapitt added 3 commits March 27, 2019 20:32

remove whitespace

7544776

sync upstream

09bb65c

sync upstream

7fef967

rapittdev force-pushed the chatops-ha branch from 7fef967 to bcb7172 Compare March 28, 2019 05:50

rapittdev and others added 2 commits April 5, 2019 09:14

deploys

7234e50

in-sync

979016c

rapittdev force-pushed the chatops-ha branch from 74731e0 to 979016c Compare April 5, 2019 11:57

rapittdev commented Apr 5, 2019

View reviewed changes

Chart.yaml Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

chatops-settings.yaml Outdated Show resolved Hide resolved

templates/configmaps_chatops.yaml Outdated Show resolved Hide resolved

templates/deployments.yaml Outdated Show resolved Hide resolved

rapittdev added 5 commits April 9, 2019 10:35

remove st2chatops.env

2258dcf

some clean up

673854d

Merge branch 'chatops-ha' of https://github.com/rapittdev/stackstorm-ha…

98c9ba7

… into chatops-ha

mounting volume

a3bec3c

manually sync files

3f7c8fc

armab added 11 commits April 12, 2019 16:50

Fix st2chatops deployment to work properly

96c4eca

Adjust st2chatops resources based on minimal requests/working state

17e0564

Adjust st2chatops resources based on minimal requests/working state

eb8da3f

Reference st2chatops imagePullPolicy, take precedence over defaults

85fbbfd

Allow defining custom st2chatops image source

06d4585

Allow configuring optional advanced settings to control pod/deploymen…

235b8a7

…t placement

Cleanup Helm templating new lines/spaces

cb7ae37

Add README description for st2chatops service

42e1c3c

Change st2chatops env to be of type Secret

23f54b7

Add TCP readiness/liveness probes for st2chatops hubot

833bbc0

Wrap-up

0ce2774

arm4b added RFR and removed WIP labels Apr 12, 2019

arm4b changed the title ~~[WIP] Chatops integration~~ Chatops integration Apr 12, 2019

arm4b approved these changes Apr 12, 2019

View reviewed changes

arm4b requested review from warrenvw and removed request for warrenvw April 12, 2019 19:53

arm4b mentioned this pull request Apr 13, 2019

Create health check API endpoint(s) that don't require auth StackStorm/st2#4020

Open

warrenvw approved these changes Apr 16, 2019

View reviewed changes

arm4b merged commit 968816b into StackStorm:master Apr 16, 2019

arm4b deleted the chatops-ha branch April 16, 2019 16:14

arm4b pushed a commit to StackStorm/st2docs that referenced this pull request Apr 16, 2019

Add st2chatops documentation

76e092f

Based on StackStorm/stackstorm-k8s#55

arm4b mentioned this pull request Apr 16, 2019

Add K8s st2chatops documentation StackStorm/st2docs#884

Merged

cognifloyd removed the RFR label Jul 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chatops integration #55

Chatops integration #55

rapittdev commented Mar 15, 2019 •

edited by arm4b

Loading

ghost commented Mar 15, 2019 •

edited by ghost

Loading

arm4b left a comment

ghost commented Mar 19, 2019 via email

arm4b left a comment

arm4b left a comment

arm4b commented Mar 25, 2019 •

edited

Loading

rapittdev commented Mar 27, 2019

ghost commented Mar 27, 2019 •

edited by ghost

Loading

rapittdev commented Apr 5, 2019 •

edited

Loading

arm4b commented Apr 5, 2019

rapittdev left a comment •

edited

Loading

rapittdev commented Apr 12, 2019

arm4b commented Apr 12, 2019

ghost commented Apr 13, 2019

ghost commented Apr 13, 2019

warrenvw left a comment

ghost commented Apr 16, 2019 •

edited by ghost

Loading

Chatops integration #55

Chatops integration #55

Conversation

rapittdev commented Mar 15, 2019 • edited by arm4b Loading

ghost commented Mar 15, 2019 • edited by ghost Loading

arm4b left a comment

Choose a reason for hiding this comment

ghost commented Mar 19, 2019 via email

arm4b left a comment

Choose a reason for hiding this comment

arm4b left a comment

Choose a reason for hiding this comment

arm4b commented Mar 25, 2019 • edited Loading

rapittdev commented Mar 27, 2019

ghost commented Mar 27, 2019 • edited by ghost Loading

rapittdev commented Apr 5, 2019 • edited Loading

arm4b commented Apr 5, 2019

rapittdev left a comment • edited Loading

Choose a reason for hiding this comment

rapittdev commented Apr 12, 2019

arm4b commented Apr 12, 2019

ghost commented Apr 13, 2019

ghost commented Apr 13, 2019

warrenvw left a comment

Choose a reason for hiding this comment

ghost commented Apr 16, 2019 • edited by ghost Loading

rapittdev commented Mar 15, 2019 •

edited by arm4b

Loading

ghost commented Mar 15, 2019 •

edited by ghost

Loading

arm4b commented Mar 25, 2019 •

edited

Loading

ghost commented Mar 27, 2019 •

edited by ghost

Loading

rapittdev commented Apr 5, 2019 •

edited

Loading

rapittdev left a comment •

edited

Loading

ghost commented Apr 16, 2019 •

edited by ghost

Loading