STAC-21039 Moving towards DataDog 7.51.1 tag. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YAML wheel build.
…YAML wheel build.
…YAML wheel build.
…pip-tools version.
…hat happened to vsphere-automation-sdk.
…re out what happened to vsphere-automation-sdk." This reverts commit 96d42b5.
…endencies between checks base and integrations.
…endencies between checks base and integrations. [2]
rb3ckers
reviewed
Sep 30, 2024
| @@ -23,7 +23,7 @@ | |||
|
|
|||
|
|
|||
| class PrometheusCheck(PrometheusScraperMixin, AgentCheck): | |||
| DEFAULT_METRIC_LIMIT = 2000 | |||
| DEFAULT_METRIC_LIMIT = 25000 | |||
There was a problem hiding this comment.
Should we do a quick check on how much more data this sends in some cases (like for StackState itself)? Or was this already the setting before?
There was a problem hiding this comment.
This has been in since may
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1: Link to Jira issue
Step 2: Description of changes
Step 3: Did you add / update tests for your changes in the right area?
Step 4: I'm confident that everything is properly tested:
I got a PO / QA Approval by:
Step 5: Can we ship this feature to production?