ref: add support for skeleton loader, and expanded tile variants #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-pei
approved these changes
Oct 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors widget components to support new skeleton loader functionality and expanded tile variants. The changes transition from a concrete Sdk type to an ISdk interface throughout the codebase and rename components to support both horizontal and vertical tile layouts.
- Replaces
Sdktype withISdkinterface across all widget components - Renames
StoryExpandedTiletoVerticalExpandedTileto support new tile variant system - Adds skeleton loader styles and functionality for improved loading experience
Reviewed Changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| widgets/waterfall/widget.tsx | Updates SDK type from Sdk to ISdk |
| widgets/utils/inline-swiper.loader.ts | Updates SDK type references throughout swiper utility |
| widgets/styles/templates/products.scss | Removes unused border-active variable and styling |
| widgets/styles/templates/expanded-tiles/_index.scss | Adds width constraint for media content |
| widgets/styles/loading/skeleton-loader.scss | Adds new skeleton loader mixin and animations |
| widgets/storyline/* | Updates SDK types and refactors to use common widget styles |
| widgets/shortvideo/* | Updates SDK types and simplifies widget configuration |
| widgets/libs/vertical-expanded-tiles/* | Renames components and updates SDK types for tile variant support |
| types/index.ts | Updates exported SDK type from Sdk to ISdk |
| tests/fixtures/widget.options.ts | Adds expanded_tile_variant configuration option |
…r-expanded-tile-variation
…kage.json and package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded tile variants will allow user to select between horizontal and vertical expanded tile.
Skeleton loader will improve loading experience of components.