Skip to content

feat: adds linter and resolves issues & creates dedicated PR and main branch pipelines #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 13, 2025
Merged

feat: adds linter and resolves issues & creates dedicated PR and main branch pipelines #38

merged 7 commits into from
May 13, 2025

Conversation

@ChrisJBurns
Copy link
Contributor

@ChrisJBurns ChrisJBurns commented May 13, 2025 •
edited
Loading

  • adds lint and lint-fix tasks
  • adds PR pipeline for testing and linting
  • adds main pipeline for testing, linting and building of artifacts
  • resolves some lint issues via task lint-fix
  • used my trusty claude code to fix the linting issues. was almost there, it got itself in a knot when refactoring the long functions and gocyclo. i had to manually do the long function change with building of logOpts and add a nolint comment for the cyclomatic complexity function as it wasn't that bad

Ref: #31

@ChrisJBurns
feat: adds linter and adds separate pipelines
649ca49 
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns
indent
b3b49ba 
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns
resolves some lint issues
4a189a2 
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns changed the title Adds linter feat: adds linter and creates dedicated PR and main branch pipelines May 13, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems May 13, 2025
View reviewed changes
ChrisJBurns and others added 4 commits May 13, 2025 13:07
@ChrisJBurns @github-advanced-security
Potential fix for code scanning alert no. 8: Workflow does not contai…
a83bc11 
…n permissions


Thank you Mr Bot.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@ChrisJBurns @github-advanced-security
Potential fix for code scanning alert no. 11: Workflow does not conta…
cdd41cb 
…in permissions


Thank you Mr Bot.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@ChrisJBurns
removes ci file as deprecated:
ef293a4 
removes ci actions as deprecated for "run-on-pr.yml" and
"run-on-main.yml"

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns
fix: addresses lint issues
77d9c96 
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns marked this pull request as ready for review May 13, 2025 13:35
@ChrisJBurns ChrisJBurns changed the title feat: adds linter and creates dedicated PR and main branch pipelines feat: adds linter and resolves issues & creates dedicated PR and main branch pipelines May 13, 2025
@ChrisJBurns ChrisJBurns merged commit 6b97bef into main May 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdimitrov rdimitrov rdimitrov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrisJBurns @rdimitrov