Skip to content

Bump github.com/mark3labs/mcp-go from 0.28.0 to 0.30.0 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
+32 −36
Merged

Bump github.com/mark3labs/mcp-go from 0.28.0 to 0.30.0 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a532b3b
Bump github.com/mark3labs/mcp-go from 0.28.0 to 0.30.0
dependabot[bot] May 26, 2025
d6e8cbe
Fix breaking changes for mcp-go v0.30.0
JAORMX May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/StacklokLabs/mkp
go 1.24.2

require (
github.com/mark3labs/mcp-go v0.28.0
github.com/mark3labs/mcp-go v0.30.0
github.com/stretchr/testify v1.10.0
k8s.io/api v0.33.1
k8s.io/apimachinery v0.33.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
github.com/mailru/easyjson v0.7.7 h1:UGYAvKxe3sBsEDzO8ZeWOSlIQfWFlxbzLZe7hwFURr0=
github.com/mailru/easyjson v0.7.7/go.mod h1:xzfreul335JAWq5oZzymOObrkdz5UnU4kGfJJLY9Nlc=
github.com/mark3labs/mcp-go v0.28.0 h1:7yl4y5D1KYU2f/9Uxp7xfLIggfunHoESCRbrjcytcLM=
github.com/mark3labs/mcp-go v0.28.0/go.mod h1:rXqOudj/djTORU/ThxYx8fqEVj/5pvTuuebQ2RC7uk4=
github.com/mark3labs/mcp-go v0.30.0 h1:Taz7fiefkxY/l8jz1nA90V+WdM2eoMtlvwfWforVYbo=
github.com/mark3labs/mcp-go v0.30.0/go.mod h1:rXqOudj/djTORU/ThxYx8fqEVj/5pvTuuebQ2RC7uk4=
github.com/moby/spdystream v0.5.0 h1:7r0J1Si3QO/kjRitvSLVVFUjxMEb/YLj6S9FF62JBCU=
github.com/moby/spdystream v0.5.0/go.mod h1:xBAYlnt/ay+11ShkdFKNAG7LsyK/tmNBVvVOwrfMgdI=
github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=
Expand Down
16 changes: 7 additions & 9 deletions pkg/mcp/get_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,13 @@ func (m *Implementation) HandleGetResource(ctx context.Context, request mcp.Call

// Parse parameters for subresources
var parameters map[string]string
if paramsRaw, exists := request.Params.Arguments["parameters"]; exists && paramsRaw != nil {
if paramsMap, ok := paramsRaw.(map[string]interface{}); ok {
parameters = make(map[string]string)
for k, v := range paramsMap {
if strVal, ok := v.(string); ok {
parameters[k] = strVal
} else {
parameters[k] = fmt.Sprintf("%v", v)
}
if paramsMap := mcp.ParseStringMap(request, "parameters", nil); paramsMap != nil {
parameters = make(map[string]string)
for k, v := range paramsMap {
if strVal, ok := v.(string); ok {
parameters[k] = strVal
} else {
parameters[k] = fmt.Sprintf("%v", v)
}
}
}
Expand Down
16 changes: 7 additions & 9 deletions pkg/mcp/post_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,13 @@ func parsePostResourceParams(request mcp.CallToolRequest) (*postResourceParams,
}

// Parse parameters for subresources
if paramsRaw, exists := request.Params.Arguments["parameters"]; exists && paramsRaw != nil {
if paramsMap, ok := paramsRaw.(map[string]interface{}); ok {
params.parameters = make(map[string]string)
for k, v := range paramsMap {
if strVal, ok := v.(string); ok {
params.parameters[k] = strVal
} else {
params.parameters[k] = fmt.Sprintf("%v", v)
}
if paramsMap := mcp.ParseStringMap(request, "parameters", nil); paramsMap != nil {
params.parameters = make(map[string]string)
for k, v := range paramsMap {
if strVal, ok := v.(string); ok {
params.parameters[k] = strVal
} else {
params.parameters[k] = fmt.Sprintf("%v", v)
}
}
}
Expand Down
30 changes: 15 additions & 15 deletions pkg/ratelimit/ratelimit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ func TestRateLimiting(t *testing.T) {

request := mcp.CallToolRequest{
Params: struct {
Name string `json:"name"`
Arguments map[string]any `json:"arguments,omitempty"`
Meta *mcp.Meta `json:"_meta,omitempty"`
Name string `json:"name"`
Arguments any `json:"arguments,omitempty"`
Meta *mcp.Meta `json:"_meta,omitempty"`
}{
Name: "test-tool",
},
Expand Down Expand Up @@ -101,9 +101,9 @@ func TestMultipleSessionRateLimiting(t *testing.T) {

request := mcp.CallToolRequest{
Params: struct {
Name string `json:"name"`
Arguments map[string]any `json:"arguments,omitempty"`
Meta *mcp.Meta `json:"_meta,omitempty"`
Name string `json:"name"`
Arguments any `json:"arguments,omitempty"`
Meta *mcp.Meta `json:"_meta,omitempty"`
}{
Name: "test-tool",
},
Expand Down Expand Up @@ -161,9 +161,9 @@ func TestWindowReset(t *testing.T) {

request := mcp.CallToolRequest{
Params: struct {
Name string `json:"name"`
Arguments map[string]any `json:"arguments,omitempty"`
Meta *mcp.Meta `json:"_meta,omitempty"`
Name string `json:"name"`
Arguments any `json:"arguments,omitempty"`
Meta *mcp.Meta `json:"_meta,omitempty"`
}{
Name: "test-tool",
},
Expand Down Expand Up @@ -209,9 +209,9 @@ func TestToolSpecificLimits(t *testing.T) {
// Test default limit tool (limit = 1)
defaultRequest := mcp.CallToolRequest{
Params: struct {
Name string `json:"name"`
Arguments map[string]any `json:"arguments,omitempty"`
Meta *mcp.Meta `json:"_meta,omitempty"`
Name string `json:"name"`
Arguments any `json:"arguments,omitempty"`
Meta *mcp.Meta `json:"_meta,omitempty"`
}{
Name: "default-tool",
},
Expand All @@ -230,9 +230,9 @@ func TestToolSpecificLimits(t *testing.T) {
// Test high limit tool (limit = 3)
highLimitRequest := mcp.CallToolRequest{
Params: struct {
Name string `json:"name"`
Arguments map[string]any `json:"arguments,omitempty"`
Meta *mcp.Meta `json:"_meta,omitempty"`
Name string `json:"name"`
Arguments any `json:"arguments,omitempty"`
Meta *mcp.Meta `json:"_meta,omitempty"`
}{
Name: "high-limit-tool",
},
Expand Down
Loading