feat: add streaming HTTP transport support #87
Merged
+80
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --transport CLI flag to select between sse and streamable-http - Add MCP_TRANSPORT environment variable support for transport selection - Create StreamableHTTPServer wrapper in pkg/mcp/server.go - Update server startup logic to use selected transport - Add documentation for transport configuration This enables MKP to work with environments like ToolHive that require HTTP-based communication. The default transport remains SSE for backward compatibility. Fixes #82
JAORMX
force-pushed
the
feat/streaming-http-transport
branch
from
7bf2823 to
28c0716
Compare
jhrozek
reviewed
Aug 18, 2025
| Shutdown(context.Context) error | ||
| } | ||
|
|
||
| switch strings.ToLower(*transport) { |
There was a problem hiding this comment.
the string is alrady ToLowered (yeah, a nit, but I read the patch!)
jhrozek
reviewed
Aug 18, 2025
| // Create SSE server | ||
| sseServer := mcp.CreateSSEServer(mcpServer) | ||
| // Create and start the appropriate transport server | ||
| var transportServer interface { |
There was a problem hiding this comment.
every single one of our MCP servers defines an interface like this. thought: should we work on a library or enhance upstream?
Collaborator
Author
There was a problem hiding this comment.
yes, a library would be a good idea.
jhrozek
approved these changes
Aug 18, 2025
Collaborator
Author
|
Not yet. I'll cut a release today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for streaming HTTP transport to enable MKP to work with environments like ToolHive that require HTTP-based communication.
Changes
--transportCLI flag to select betweensse(default) andstreamable-httptransport protocolsMCP_TRANSPORTenvironment variable for transport selectionCreateStreamableHTTPServer()function inpkg/mcp/server.goto instantiate StreamableHTTP servercmd/server/main.goto dynamically select and start the appropriate transportWhy This Change?
As reported in #82, the current implementation only supports SSE transport, which doesn't work with ToolHive's ingress setup. ToolHive sets the
MCP_TRANSPORTenvironment variable tostreamable-httpwhen it needs HTTP-based communication.This implementation:
MCP_TRANSPORTenv var)Testing
Fixes #82