feat: remove private prompts on related brain delete

[mamadoudicko]

Description

• Improve personality picker ui
• Remove private prompts on related brains deletion

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 4, 2023 7:31am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 4, 2023 7:31am

[github-actions]

LOGAF Level 3 - /home/runner/work/quivr/quivr/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/PublicPrompts/components/PublicPromptsList/hooks/usePublicPromptsList.ts

1. The useEffect hook is used to add and remove an event listener for clicks outside of the dropdown. This could be abstracted into a custom hook for better readability and reusability. For example:

function useClickOutside(ref: RefObject<HTMLElement>, handler: (event: MouseEvent) => void) {
  useEffect(() => {
    const listener = (event: MouseEvent) => {
      if (ref.current && !ref.current.contains(event.target as Node)) {
        handler(event);
      }
    };

    document.addEventListener('click', listener);

    return () => {
      document.removeEventListener('click', listener);
    };
  }, [ref, handler]);
}

2. The onChange and onSelect callbacks are called with an object that includes the title and content of the selected option. This could be simplified by passing the entire Prompt object, allowing the parent component to decide which properties it needs.

---

LOGAF Level 2 - /home/runner/work/quivr/quivr/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/PublicPrompts/components/PublicPromptsList/PublicPromptsList.tsx

1. The PublicPromptsList component is well-written, but it could be improved by adding PropTypes or TypeScript interfaces to validate the props.

2. The handleOptionClick function could be simplified. Instead of passing the entire option object, you could just pass the option.id and find the corresponding option in the parent component.

Example:

onClick={() => handleOptionClick(option.id)}

---

LOGAF Level 1 - /home/runner/work/quivr/quivr/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/PublicPrompts/PublicPrompts.tsx

The PublicPrompts component is well-written and doesn't require any changes. However, it would be beneficial to add comments to explain what the component does and how it works.

---

🔨💡📝

---

Powered by Code Review GPT

[gozineb]

Omg what is this

[gozineb]

Let's split this file. Let's have a Prompt folder with components, hooks and types in different files

[gozineb]

Split the code