Feat/sentry error boundary #1650
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There is also a new zod plugin for sentry getsentry/sentry-javascript#11144, this should allow for better grouping for validation related errors And this integration that should add more error data from third-party errors https://docs.sentry.io/platforms/javascript/guides/nextjs/configuration/integrations/extraerrordata/ |
we already have |
| scope.setExtras(extras) | ||
| } | ||
|
|
||
| scope.setLevel(severityLevel ?? 'warning') |
There was a problem hiding this comment.
Default should be error here, same as not setting it at all
There was a problem hiding this comment.
thanks. adjusted it
|
|
||
| return scope | ||
| }} | ||
| fallback={fallback ?? ErrorFallbackComponent} |
There was a problem hiding this comment.
The idea is to not have a fallback, this would create weird UI in some cases and is explicitly not the idea of that TDD, we don't want to change behavior or how we treat errors, all we want to do here is add metadata to the generic ones that are gonna be captured automatically
There was a problem hiding this comment.
cool, you're right. removed it
| import { NextImage } from '@/components/ui/image' | ||
| import { PageTitle } from '@/components/ui/pageTitleText' | ||
|
|
||
| export function ErrorFallbackComponent() { |
There was a problem hiding this comment.
See comment bellow, but we shouldn't have this here
closes https://github.com/Stand-With-Crypto/swc-internal/issues/302
fixes
What changed? Why?
PlanetScale deploy request
Notes to reviewers
How has it been tested?