Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: investigate and fix middleware cookie creation #1833

Merged
merged 11 commits into from
Feb 13, 2025

Conversation

twistershark
Copy link
Contributor

closes #1828

What changed? Why?

This PR re-adds the current page country code cookie creation in our middleware without breaking the sign-in flow for wallets on static pages.

How has it been tested?

  • Locally
  • Vercel Preview Branch
  • Unit test
  • Functional test

@twistershark twistershark self-assigned this Feb 11, 2025
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swc-web ✅ Ready (Inspect) Visit Preview Feb 13, 2025 2:18pm

olavoparno
olavoparno previously approved these changes Feb 12, 2025
@twistershark twistershark merged commit 18e88bd into main Feb 13, 2025
3 checks passed
@twistershark twistershark deleted the 1828/investigate-and-fix-middleware-cookie-creation branch February 13, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and fix middleware countryCode cookie creation
3 participants