-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Deployment Setup #40
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 27.26% 27.26%
=======================================
Files 181 181
Lines 6296 6296
Branches 299 299
=======================================
Hits 1716 1716
Misses 4486 4486
Partials 94 94 Continue to review full report in Codecov by Sentry.
|
@arkadiuszbachorski Created this PR to investigate the deployment setup as noted on Slack. We should verify that it properly works on this branch + with the combination of injecting the secrets using the deployment environment. |
.github/workflows/deployment.yml
Outdated
arguments: '--project ${{ needs.vars.outputs.FIREBASE_PROJECT_ID }}' | ||
secrets: | ||
GOOGLE_APPLICATION_CREDENTIALS_BASE64: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_BASE64 }} | ||
ENV_FILE: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed. ENV_FILE
is used only for docker-compose-test.yml
action, it's not used in firebase-deploy.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at it and it seems to be correctly configured. I'll go ahead and merge this to verify. |
Improve Deployment Setup
⚙️ Release Notes
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: