Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Deployment Setup #40

Merged
merged 8 commits into from
Sep 10, 2024
Merged

Improve Deployment Setup #40

merged 8 commits into from
Sep 10, 2024

Conversation

PSchmiedmayer
Copy link
Member

Improve Deployment Setup

⚙️ Release Notes

  • Switch from Firebase App Hosting to Firebase Hosting

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Sep 6, 2024
@PSchmiedmayer PSchmiedmayer self-assigned this Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.26%. Comparing base (8d8078f) to head (0bf2411).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   27.26%   27.26%           
=======================================
  Files         181      181           
  Lines        6296     6296           
  Branches      299      299           
=======================================
  Hits         1716     1716           
  Misses       4486     4486           
  Partials       94       94           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d8078f...0bf2411. Read the comment docs.

@PSchmiedmayer
Copy link
Member Author

@arkadiuszbachorski Created this PR to investigate the deployment setup as noted on Slack.

We should verify that it properly works on this branch + with the combination of injecting the secrets using the deployment environment.

arguments: '--project ${{ needs.vars.outputs.FIREBASE_PROJECT_ID }}'
secrets:
GOOGLE_APPLICATION_CREDENTIALS_BASE64: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_BASE64 }}
ENV_FILE: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed. ENV_FILE is used only for docker-compose-test.yml action, it's not used in firebase-deploy.yml

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arkadiuszbachorski
Copy link
Collaborator

I looked at it and it seems to be correctly configured. I'll go ahead and merge this to verify.

@arkadiuszbachorski arkadiuszbachorski merged commit 3168b31 into main Sep 10, 2024
10 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the deployment branch September 10, 2024 14:49
@PSchmiedmayer PSchmiedmayer mentioned this pull request Sep 11, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants