Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup throughout the app #40

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Small cleanup throughout the app #40

merged 4 commits into from
Dec 1, 2023

Conversation

philippzagar
Copy link
Contributor

@philippzagar philippzagar commented Nov 30, 2023

Small cleanup throughout the app

♻️ Current situation & Problem

Currently, the application uses unnecessary and redundant functionalities that accumulated over time.

⚙️ Release Notes

  • Small cleanup of the application to ensure clean and maintainable code

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Nov 30, 2023
@philippzagar philippzagar self-assigned this Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #40 (bb22f55) into main (a24b5bc) will increase coverage by 0.29%.
The diff coverage is 97.62%.

❗ Current head bb22f55 differs from pull request most recent head 73f1cd6. Consider uploading reports for the commit 73f1cd6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   41.19%   41.47%   +0.29%     
==========================================
  Files          32       31       -1     
  Lines        1219     1225       +6     
==========================================
+ Hits          502      508       +6     
  Misses        717      717              
Files Coverage Δ
.../FHIR Interpretation/FHIRResource+Extensions.swift 0.00% <ø> (ø)
LLMonFHIR/Onboarding/Disclaimer.swift 100.00% <100.00%> (ø)
LLMonFHIR/Onboarding/HealthKitPermissions.swift 95.24% <100.00%> (ø)
LLMonFHIR/Onboarding/Welcome.swift 100.00% <100.00%> (ø)
LLMonFHIR/FHIR Interpretation/LLMFunction.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24b5bc...73f1cd6. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great additions! 🚀

@philippzagar philippzagar enabled auto-merge (squash) December 1, 2023 01:14
@philippzagar philippzagar merged commit e74f9ef into main Dec 1, 2023
4 checks passed
@philippzagar philippzagar deleted the feat/cleanup branch December 1, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants