Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated GoogleService Info plist for Firebase integration #13

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jun 20, 2023

Add updated GoogleService Info plist for Firebase integration

♻️ Current situation & Problem

Currently, we currently solely rely on the firebase emulator.

💡 Proposed solution

This PR adds the necessary configuration files to back the deployed App with the corresponding firebase project.

⚙️ Release Notes

  • Added firebase for the deployed app

➕ Additional Information

Related PRs

--

Testing

--

Reviewer Nudging

Simple configuration change.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer
Copy link
Member

@Supereg Took a look at the PR. The last issue that is remaining is the scheduler issue that you described in #12.

If you bring StanfordSpezi/SpeziTemplateApplication#24 into this PR this should resolve the build issues and you can merge the PR 🚀

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #13 (3ccc130) into main (7bcad83) will decrease coverage by 1.65%.
The diff coverage is 95.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   92.98%   91.32%   -1.65%     
==========================================
  Files          26       24       -2     
  Lines         655      576      -79     
==========================================
- Hits          609      526      -83     
- Misses         46       50       +4     
Impacted Files Coverage Δ
NAMS/Helper/CodableArray+RawRepresentable.swift 42.86% <ø> (ø)
NAMS/NAMSAppDelegate.swift 96.78% <ø> (-0.95%) ⬇️
NAMS/Onboarding/AccountSetup/IconView.swift 100.00% <ø> (ø)
NAMS/Onboarding/AccountSetup/NAMSLogin.swift 0.00% <ø> (ø)
NAMS/Onboarding/AccountSetup/NAMSSignUp.swift 100.00% <ø> (ø)
NAMS/Schedule/NAMSTaskContext.swift 50.00% <ø> (ø)
NAMS/Onboarding/AccountSetup/AccountSetup.swift 92.64% <62.50%> (-2.87%) ⬇️
NAMS/Home.swift 100.00% <100.00%> (ø)
NAMS/NAMSApp.swift 100.00% <100.00%> (ø)
NAMS/NAMSTestingSetup.swift 100.00% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40244c1...3ccc130. Read the comment docs.

@Supereg Supereg merged commit 609eaa9 into main Jun 23, 2023
@Supereg Supereg deleted the feature/firebase-integration branch June 23, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants