Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Spezi Onboarding #21

Merged
merged 4 commits into from
Sep 16, 2023
Merged

Upgrade Spezi Onboarding #21

merged 4 commits into from
Sep 16, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Sep 16, 2023

Upgrade Spezi Onboarding

♻️ Current situation & Problem

Currently, we still rely on the old style way of navigating the onboarding flow.

💡 Proposed solution

This PR upgrades to the OnboardingStack of the latest SpeziOnboarding release.

⚙️ Release Notes

  • Upgraded SpeziOnboarding infrastructure

➕ Additional Information

Related PRs

Testing

Tests were adjusted.

Reviewer Nudging

Refer to the linked PR.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #21 (08304f2) into main (53546b6) will decrease coverage by 6.02%.
The diff coverage is 86.05%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   84.84%   78.82%   -6.02%     
==========================================
  Files          26       28       +2     
  Lines         732      708      -24     
==========================================
- Hits          621      558      -63     
- Misses        111      150      +39     
Files Changed Coverage Δ
NAMS/Onboarding/AccountSetup/IconView.swift 100.00% <ø> (ø)
NAMS/Onboarding/AccountSetup/UserView.swift 100.00% <ø> (ø)
...S/Onboarding/OnboardingFlow+PreviewSimulator.swift 0.00% <0.00%> (ø)
NAMS/Onboarding/AccountSetup/AccountSetup.swift 93.03% <70.00%> (-0.43%) ⬇️
NAMS/Helper/ProcessInfo+PreviewSimulator.swift 100.00% <100.00%> (ø)
NAMS/Onboarding/FinishedSetup.swift 100.00% <100.00%> (ø)
NAMS/Onboarding/NotificationPermissions.swift 95.46% <100.00%> (-0.10%) ⬇️
NAMS/Onboarding/OnboardingFlow.swift 100.00% <100.00%> (+4.00%) ⬆️
NAMS/Onboarding/Welcome.swift 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53546b6...08304f2. Read the comment docs.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Supereg Supereg merged commit 3e6c967 into main Sep 16, 2023
@Supereg Supereg deleted the feature/upgrade-spezi-onboarding branch September 16, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant