Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new SpeziAccount #33

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Upgrade to new SpeziAccount #33

merged 4 commits into from
Oct 26, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 26, 2023

Upgrade to new SpeziAccount

♻️ Current situation & Problem

We currently use a lot of old Spezi framework dependencies.

💡 Proposed solution

This PR upgrades SpeziAccount and all Spezi framework dependencies.

⚙️ Release Notes

  • Upgrade SpeziAccount with new Account Setup flow and new Account Overview

➕ Additional Information

We moved the EEG Recordings view into a TabBar item for now.

Related PRs & Issues

Testing

Tests were updated.

Reviewer Nudging

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg mentioned this pull request Oct 26, 2023
1 task
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #33 (7d3072e) into main (44e4e96) will increase coverage by 3.86%.
The diff coverage is 92.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   79.49%   83.35%   +3.86%     
==========================================
  Files          63       62       -1     
  Lines        2291     2269      -22     
==========================================
+ Hits         1821     1891      +70     
+ Misses        470      378      -92     
Files Coverage Δ
NAMS/Account/AccountButton.swift 100.00% <100.00%> (ø)
NAMS/Account/AccountSetupHeader.swift 100.00% <100.00%> (ø)
NAMS/Contacts/Contacts.swift 91.84% <100.00%> (+1.60%) ⬆️
NAMS/EEG/EEGDeviceDetails.swift 77.59% <100.00%> (ø)
NAMS/Home.swift 93.75% <100.00%> (+2.38%) ⬆️
NAMS/NAMSApp.swift 100.00% <100.00%> (ø)
NAMS/Onboarding/NotificationPermissions.swift 95.46% <100.00%> (ø)
NAMS/Onboarding/OnboardingFlow.swift 100.00% <100.00%> (ø)
NAMS/Onboarding/Welcome.swift 100.00% <100.00%> (ø)
NAMS/Patients/AddPatientView.swift 90.42% <100.00%> (+1.71%) ⬆️
... and 11 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e4e96...7d3072e. Read the comment docs.

@Supereg Supereg enabled auto-merge (squash) October 26, 2023 06:18
@Supereg Supereg linked an issue Oct 26, 2023 that may be closed by this pull request
1 task
@Supereg Supereg disabled auto-merge October 26, 2023 17:07
@Supereg Supereg merged commit 67e9271 into main Oct 26, 2023
@Supereg Supereg deleted the feature/upgrade-spezi-account branch October 26, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump SpeziAccount and other dependencies
1 participant