Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release builds #36

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix release builds #36

merged 2 commits into from
Oct 27, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 26, 2023

Fix release builds

♻️ Current situation & Problem

With the latest changes of adding a new ScheduleView and the M-CHAT R/F questionnaires (see #35), we broke the release build action.

💡 Proposed solution

This PR fixes the compilation issues and adds a PR Action step to verify release build before merging a PR.

⚙️ Release Notes

  • Fix release builds

➕ Additional Information

Related PRs

--

Testing

GitHub Action was added to build the release scheme for every PR.

Reviewer Nudging

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #36 (3965f86) into main (105f8bd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files          63       63           
  Lines        2306     2306           
=======================================
  Hits         1959     1959           
  Misses        347      347           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105f8bd...3965f86. Read the comment docs.

@Supereg Supereg marked this pull request as ready for review October 27, 2023 00:05
@Supereg Supereg merged commit f2d9786 into main Oct 27, 2023
@Supereg Supereg deleted the fix/muse-target branch October 27, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant