Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize Biopot measurements #46

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Dec 2, 2023

Visualize Biopot measurements

♻️ Current situation & Problem

The biopot device integration is currently relatively limited. With #41 we introduced initial pairing functionality based on SpeziBluetooth and #45 introduced parsing the BLE layer. This PR does first steps to integrate the Biopot device into the existing device search infrastructure and aims to display live data from the device.

⚙️ Release Notes

  • Integrate Biopot devices into the nearby devices list.
  • Visualize live measurements from the currently connected Biopot.

📚 Documentation

--

✅ Testing

TBA

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Sorry, something went wrong.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #46 (344c5d0) into main (ff0752a) will decrease coverage by 2.57%.
The diff coverage is 59.27%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   85.07%   82.50%   -2.57%     
==========================================
  Files          78       84       +6     
  Lines        2900     3114     +214     
==========================================
+ Hits         2467     2569     +102     
- Misses        433      545     +112     
Files Coverage Δ
NAMS/Devices/BatteryIcon.swift 79.32% <ø> (ø)
...AMS/Devices/BioPot/Model/AccelerometerSample.swift 85.72% <ø> (ø)
NAMS/Devices/BioPot/Model/ByteBuffer+Int24.swift 80.44% <ø> (ø)
NAMS/Devices/BioPot/Model/DataAcquisition.swift 88.64% <ø> (ø)
NAMS/Devices/BioPot/Model/DataControl.swift 73.69% <ø> (ø)
...AMS/Devices/BioPot/Model/DeviceConfiguration.swift 95.35% <ø> (ø)
NAMS/Devices/BioPot/Model/DeviceInformation.swift 92.00% <ø> (ø)
NAMS/Devices/BioPot/Model/EEGSample.swift 70.59% <ø> (ø)
...S/Devices/BioPot/Model/SamplingConfiguration.swift 76.09% <ø> (ø)
NAMS/Devices/DevicesSheet.swift 100.00% <100.00%> (ø)
... and 29 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0752a...344c5d0. Read the comment docs.

@Supereg Supereg marked this pull request as ready for review December 5, 2023 00:16
@Supereg Supereg merged commit c448c04 into main Dec 5, 2023
@Supereg Supereg deleted the feature/biopot-device-integration branch December 5, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant