Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Patient Management Prototype #9

Merged
merged 15 commits into from
Oct 26, 2023
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jun 11, 2023

Initial Patient Management Prototype

♻️ Current situation & Problem

Currently, the app doesn't implement any way manage the list of patients. Particularly, the following actions are required:

  • The concept of an active patient (questionnaires, egg recordings, ...)
  • Ability to select the active patient from a list of available patients
  • Ability to add, edit or remove patient information

💡 Proposed solution

This PR creates an initial prototype of the patient management system backed by Firestore. We introduce the concept of a "Selected Patient" and make that central to the "Schedule View". Device Pairing and Questionnaires will only be available if one selects a patient. Though, currently we don't yet associate any of the data with the patient records.

⚙️ Release Notes

  • Add the initial prototype of the patient management system

➕ Additional Information

Related PRs

--

Testing

Extensive UI testing was added.

Reviewer Nudging

Ideally, open the Simulator (or Xcode previews) to get yourself familiar with the UI. Then try to navigate the corresponding source code, starting from the PatientList view.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg force-pushed the feature/patient-management branch from 6302636 to f817b00 Compare June 12, 2023 00:10
@Supereg Supereg force-pushed the feature/patient-management branch from f817b00 to 546684b Compare September 26, 2023 15:54
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #9 (3192a11) into main (e7e2c04) will decrease coverage by 1.79%.
The diff coverage is 84.68%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   81.29%   79.49%   -1.79%     
==========================================
  Files          49       63      +14     
  Lines        1608     2291     +683     
==========================================
+ Hits         1307     1821     +514     
- Misses        301      470     +169     
Files Coverage Δ
NAMS/EEG/EEGChart.swift 96.50% <100.00%> (ø)
NAMS/EEG/EEGDeviceRow.swift 89.89% <100.00%> (-0.22%) ⬇️
NAMS/EEG/EEGRecording.swift 93.66% <100.00%> (ø)
NAMS/EEG/ListRow.swift 100.00% <ø> (ø)
NAMS/EEG/NearbyDevices.swift 73.56% <100.00%> (ø)
NAMS/Helper/CodableArray+RawRepresentable.swift 0.00% <ø> (ø)
NAMS/Helper/CollectionReference+AsyncAwait.swift 100.00% <100.00%> (ø)
NAMS/Misc/NoInformationText.swift 100.00% <100.00%> (ø)
NAMS/Onboarding/NotificationPermissions.swift 95.46% <100.00%> (ø)
NAMS/Patients/CurrentPatientLabel.swift 100.00% <100.00%> (ø)
... and 16 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e2c04...3192a11. Read the comment docs.

@Supereg Supereg force-pushed the feature/patient-management branch from ef9e386 to 7533ebf Compare October 23, 2023 22:12
@Supereg Supereg marked this pull request as ready for review October 25, 2023 23:36
@Supereg Supereg changed the title Patient Management Initial Patient Management Prototype Oct 25, 2023
@Supereg Supereg merged commit 44e4e96 into main Oct 26, 2023
@Supereg Supereg deleted the feature/patient-management branch October 26, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant