Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Links #49

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Contact Links #49

merged 1 commit into from
Feb 23, 2024

Conversation

MatthewTurk247
Copy link
Collaborator

Contact Links

♻️ Current situation & Problem

Hot fix addresses #53 by replacing previous (internal) bio links on the Contacts tab with public-facing Stanford profiles.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 28.26%. Comparing base (4458bfd) to head (994966b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      StanfordBDHG/.github#49   +/-   ##
=======================================
  Coverage   28.26%   28.26%           
=======================================
  Files          34       34           
  Lines        1228     1228           
=======================================
  Hits          347      347           
  Misses        881      881           
Files Coverage Δ
PAWS/Contacts/Contacts.swift 66.30% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4458bfd...994966b. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MatthewTurk247 🚀

@PSchmiedmayer PSchmiedmayer merged commit 57e9b6d into main Feb 23, 2024
6 of 7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the contact-links branch February 23, 2024 06:56
@PSchmiedmayer PSchmiedmayer added the bug Something isn't working label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants