-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for visionOS and macOS #20
Conversation
Would require an updated branch protection 👍 |
Couple issues here with the visionOS builds. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 73.01% 78.83% +5.83%
==========================================
Files 4 10 +6
Lines 263 392 +129
==========================================
+ Hits 192 309 +117
- Misses 71 83 +12
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@PSchmiedmayer this PR is ready to review and merge. The branch protection rules would need an update due to changes to the job names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the additions 🎉
Optimize text input on visionOS
♻️ Current situation & Problem
The current approach for textfield selection does not work on visionOS. This PR addresses the issue by replacing the current solution via a simple "tap" on visionOS. Our automatic text input correction should catch the case where the tap will set the cursor in the middle of the text.
This resolves #19.
Further, keyboards and alerts are in separate processes in visionOS. This PR accounts for that and updates the respective implementations.
⚙️ Release Notes
📚 Documentation
Minor adjustments.
✅ Testing
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: