Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for keyboard appearing on catalyst #21

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Feb 21, 2024

Don't check for keyboard appearing on catalyst

♻️ Current situation & Problem

For our text entry implementation, we currently maintain a special check for macOS to not check for keyboard existence (as there is no UI keyboard don macOS). This check currently isn't used on the catalyst platform. This PR fixes that for macOS Catalyst as well.

⚙️ Release Notes

  • Fix text entry for macOS catalyst builds

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e29d29d) 78.58% compared to head (d7d87c9) 78.58%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files          10       10           
  Lines         392      392           
=======================================
  Hits          308      308           
  Misses         84       84           
Files Coverage Δ
...urces/XCTestExtensions/XCUIElement+TextEntry.swift 92.82% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29d29d...d7d87c9. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg!

@Supereg Supereg merged commit 1fe9b8e into main Feb 22, 2024
11 checks passed
@Supereg Supereg deleted the fix/mac-catalyst-text-input branch February 22, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants