Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Strict Concurrency #23

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Swift Strict Concurrency #23

merged 2 commits into from
Jul 2, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jul 1, 2024

Swift Strict Concurrency

♻️ Current situation & Problem

Enable Swift strict concurrency and some concurrency fixes.

⚙️ Release Notes

  • Enable Swift strict concurrency and some concurrency fixes.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.50%. Comparing base (1fe9b8e) to head (39579ea).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   78.83%   85.50%   +6.68%     
==========================================
  Files          10        6       -4     
  Lines         392      331      -61     
==========================================
- Hits          309      283      -26     
+ Misses         83       48      -35     
Files Coverage Δ
...xtensions/XCTestCase+DisablePasswordAutofill.swift 71.67% <ø> (+45.36%) ⬆️
...urces/XCTestExtensions/XCUIElement+TextEntry.swift 92.82% <ø> (ø)
...s/XCTestExtensions/XCTAssertThrowsErrorAsync.swift 80.00% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69eae1a...39579ea. Read the comment docs.

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Jul 1, 2024
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this and resolving the warnings @Supereg!

@Supereg Supereg merged commit cc2705f into main Jul 2, 2024
10 of 11 checks passed
@Supereg Supereg deleted the fix/sendability branch July 2, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants