Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionnaire Flattener #12

Merged
merged 57 commits into from
Apr 29, 2024
Merged

Questionnaire Flattener #12

merged 57 commits into from
Apr 29, 2024

Conversation

AdritRao
Copy link
Member

@AdritRao AdritRao commented Apr 6, 2024

Questionnaire Flattener

♻️ Current situation & Problem

The issue is https://github.com/StanfordSpezi/SpeziDataPipelineTemplate/issues/11. The flattener for questionnaire responses should be able to use phoenix-generated surveys to convert the question and response IDs in Firebase to text.

⚙️ Release Notes

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@AdritRao AdritRao changed the base branch from main to defineAPISurface April 6, 2024 05:47
@PSchmiedmayer PSchmiedmayer requested a review from Vicbi April 6, 2024 09:13
@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Apr 6, 2024
Copy link
Collaborator

@Vicbi Vicbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work @AdritRao ! I went through the QuestionnaireResponseFlattener() and I've provided a couple of comments and suggestions. Let me know what you think and we can sync back! 🙌

SpeziDataPipelineTemplate.ipynb Outdated Show resolved Hide resolved
data_flattening/fhir_resources_flattener.py Outdated Show resolved Hide resolved
data_flattening/fhir_resources_flattener.py Outdated Show resolved Hide resolved
data_flattening/fhir_resources_flattener.py Outdated Show resolved Hide resolved
data_flattening/fhir_resources_flattener.py Outdated Show resolved Hide resolved
data_flattening/fhir_resources_flattener.py Outdated Show resolved Hide resolved
@AdritRao
Copy link
Member Author

Thank you for reviewing the PR @Vicbi! I have modified the code based on your suggestions in the recent commits. Please let me know if you have any other suggestions.

Base automatically changed from defineAPISurface to main April 22, 2024 23:17
@Vicbi
Copy link
Collaborator

Vicbi commented Apr 23, 2024

Hi @AdritRao,

Great job addressing the comments, and thanks for your efforts! 🚀

I've merged the main branch into survey_flattener and resolved the resulting conflicts. Feel free to review the updated branch. Also, it would be super helpful if you could address the lint issues reported in the GitHub Actions (e.g.,. adding documentation to the class/functions and performing some refactoring) before we proceed with the merge. Let me know if you need any clarifications!

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 44.48%. Comparing base (c519aa9) to head (5b0cb7f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   46.05%   44.48%   -1.57%     
==========================================
  Files          10       10              
  Lines         721      796      +75     
==========================================
+ Hits          332      354      +22     
- Misses        389      442      +53     
Flag Coverage Δ
unittests 44.48% <33.34%> (-1.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
data_visualization/data_visualizer.py 35.27% <ø> (ø)
data_flattening/fhir_resources_flattener.py 55.94% <33.34%> (-12.39%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c519aa9...5b0cb7f. Read the comment docs.

@Vicbi
Copy link
Collaborator

Vicbi commented Apr 29, 2024

Thank you @AdritRao for working on the pylint issues! 🚀 I've made some additional modifications and I am happy to merge the branch to main!

@Vicbi Vicbi merged commit 9d25173 into main Apr 29, 2024
9 checks passed
@Vicbi Vicbi deleted the survey_flattener branch April 29, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants