-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questionnaire Flattener #12
Conversation
…PipelineTemplate into defineAPISurface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your great work @AdritRao ! I went through the QuestionnaireResponseFlattener() and I've provided a couple of comments and suggestions. Let me know what you think and we can sync back! 🙌
Thank you for reviewing the PR @Vicbi! I have modified the code based on your suggestions in the recent commits. Please let me know if you have any other suggestions. |
Hi @AdritRao, Great job addressing the comments, and thanks for your efforts! 🚀 I've merged the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 46.05% 44.48% -1.57%
==========================================
Files 10 10
Lines 721 796 +75
==========================================
+ Hits 332 354 +22
- Misses 389 442 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Thank you @AdritRao for working on the pylint issues! 🚀 I've made some additional modifications and I am happy to merge the branch to main! |
Questionnaire Flattener
♻️ Current situation & Problem
The issue is https://github.com/StanfordSpezi/SpeziDataPipelineTemplate/issues/11. The flattener for questionnaire responses should be able to use phoenix-generated surveys to convert the question and response IDs in Firebase to text.
⚙️ Release Notes
flatten_fhir_resources
and for the question and answer mappings to be extracted. For the questions, I mapped the linkId to the text. For answers, because they have both a system ID and choice code, I combined the system id and code and used that as the mapping key. https://github.com/StanfordSpezi/SpeziDataPipelineTemplate/blob/cca4c5d2501a1b66234c240f0066aa39dfc0fc6b/data_flattening/fhir_resources_flattener.py#L508📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: