Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Spezi Data Pipeline for PyPI Distribution #14

Merged
merged 41 commits into from
May 23, 2024
Merged

Conversation

Vicbi
Copy link
Collaborator

@Vicbi Vicbi commented Apr 30, 2024

Prepare Spezi Data Pipeline for PyPI Distribution

♻️ Current situation & Problem

This PR addresses the necessary configuration and organization for distributing the Spezi Data Pipeline tool through PyPI Issue #13.

⚙️ Release Notes

  • Develops comprehensive tests to ensure functionality.
  • Implements Hatch as the package manager to handle project environments and dependencies.
  • Reorganizes the project to adopt the standard Python package structure.

📚 Documentation

Documentation is updated.

✅ Testing

The testing suite has been expanded to cover most functionalities according to the coverage criteria set by CodeCov.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 83.22148% with 75 lines in your changes are missing coverage. Please review.

Project coverage is 78.06%. Comparing base (9d25173) to head (72dfd46).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #14       +/-   ##
===========================================
+ Coverage   44.48%   78.06%   +33.58%     
===========================================
  Files          10       15        +5     
  Lines         796     1180      +384     
===========================================
+ Hits          354      921      +567     
+ Misses        442      259      -183     
Flag Coverage Δ
unittests 78.06% <83.23%> (+33.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
..._pipeline/data_access/firebase_fhir_data_access.py 79.29% <100.00%> (ø)
...peline/data_flattening/fhir_resources_flattener.py 92.44% <100.00%> (ø)
...pezi_data_pipeline/data_processing/code_mapping.py 100.00% <100.00%> (ø)
...zi_data_pipeline/data_processing/data_processor.py 70.77% <100.00%> (ø)
tests/test_data_access.py 99.09% <100.00%> (+4.09%) ⬆️
tests/test_data_exploration.py 97.37% <100.00%> (ø)
...c/spezi_data_pipeline/data_export/data_exporter.py 78.27% <80.00%> (ø)
tests/test_data_process.py 98.12% <98.12%> (ø)
tests/test_data_export.py 94.60% <94.60%> (ø)
scripts/update_authors.py 82.61% <82.61%> (ø)
... and 5 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d25173...72dfd46. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the improvement @Vicbi!

I looked at the different changes and improvements and added comments throughout the code. Mostly around the automation setup and elements around this.

Thank you for adding so many tests in this PR; provides tremendous value!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/publish-to-pypi.yml Show resolved Hide resolved
.github/workflows/publish-to-pypi.yml Outdated Show resolved Hide resolved
.github/workflows/publish-to-pypi.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the improvements @Vicbi! I only had a few comments on restructuring the GitHub Actions and when the different scripts should be called.

Feel free to merge the PR once these elements are addressed, thank you for all the work that went into the PR, the improvements in test coverage are really nice 🚀

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Show resolved Hide resolved
.github/workflows/publish-to-pypi.yml Outdated Show resolved Hide resolved
.github/workflows/publish-to-pypi.yml Show resolved Hide resolved
CONTRIBUTORS.md Outdated Show resolved Hide resolved
.github/workflows/publish-to-pypi.yml Show resolved Hide resolved
.github/workflows/update-authors.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
update_authors.py Outdated Show resolved Hide resolved
@Vicbi Vicbi merged commit 614093c into main May 23, 2024
10 checks passed
@Vicbi Vicbi deleted the pypi-package-setup branch May 23, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants