Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate risk scores for questionnaires/surveys #19

Merged
merged 68 commits into from
Jul 2, 2024
Merged

Conversation

Vicbi
Copy link
Collaborator

@Vicbi Vicbi commented Jun 11, 2024

Calculate risk scores for questionnaires/surveys

⚙️ Release Notes

Add functionality to calculate the risk score from questionnaires and visualise variation with time.

📚 Documentation

Update README.md file to include questionnaire-related functionalities.

✅ Testing

Add tests to ensure proper functionality.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 87.90497% with 56 lines in your changes missing coverage. Please review.

Project coverage is 83.51%. Comparing base (6e61a75) to head (ca3f6b0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   77.25%   83.51%   +6.27%     
==========================================
  Files          15       16       +1     
  Lines        1182     1564     +382     
==========================================
+ Hits          913     1306     +393     
+ Misses        269      258      -11     
Flag Coverage Δ
unittests 83.51% <87.91%> (+6.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
..._pipeline/data_access/firebase_fhir_data_access.py 79.29% <100.00%> (+0.15%) ⬆️
...c/spezi_data_pipeline/data_export/data_exporter.py 77.78% <100.00%> (ø)
..._pipeline/data_processing/observation_processor.py 32.84% <100.00%> (ø)
tests/test_data_access.py 99.08% <100.00%> (ø)
tests/test_data_exploration.py 98.93% <100.00%> (+1.63%) ⬆️
tests/test_data_export.py 94.45% <ø> (ø)
tests/test_data_flattening.py 91.23% <100.00%> (+5.52%) ⬆️
tests/test_data_process.py 98.84% <100.00%> (+0.77%) ⬆️
tests/test_update_configuration_file.py 86.05% <ø> (ø)
...zi_data_pipeline/data_exploration/data_explorer.py 72.69% <90.00%> (+29.53%) ⬆️
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e61a75...ca3f6b0. Read the comment docs.

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Jul 1, 2024
@PSchmiedmayer
Copy link
Member

@Vicbi Thank you for continuing to work on the PR, let me know if you need any additional input on this PR 🚀

@PSchmiedmayer PSchmiedmayer self-requested a review July 2, 2024 05:39
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Vicbi for the additional improvements and test cases!

Only had very minor comments; feel free to merge the PR 🚀

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/publish-to-pypi.yml Show resolved Hide resolved
.github/workflows/publish-to-pypi.yml Outdated Show resolved Hide resolved
SpeziDataPipelineTemplateForSurveys.ipynb Outdated Show resolved Hide resolved
@Vicbi Vicbi merged commit d73bbf5 into main Jul 2, 2024
11 checks passed
@Vicbi Vicbi deleted the calculate-risk-scores branch July 2, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants