-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix syntax error in version check command #21
Conversation
…dated documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 83.51% 82.87% -0.63%
==========================================
Files 16 16
Lines 1564 1582 +18
==========================================
+ Hits 1306 1311 +5
- Misses 258 271 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this @Vicbi and fixing the deployment issues.
One thing that I also noticed is that we also don't have the documentation deployment to a GitHub page anymore. Not sure where this was lost exactly but it would be great to get this back to ensure that we deploy our documentation to the GitHub page to point people to all the great code documentation you have written 🚀
Thanks @PSchmiedmayer for pointing out to the documentation deployment! I need to investigate why this happened. In addition, it looks like there is an issue with the trusted publisher leading to this error I was wondering whether we need to update the trusted publisher configuration on the PyPI account to reflect the new repository name. |
@Vicbi You are right; that must be the issue. I updated the repo name in the testing and production version of pypi.org for the StanfordSpezi account 🚀 |
Thank you for re-adding the documentation deployment 👍 |
Awesome! Thank you for updating the configuration @PSchmiedmayer ! |
…DataPipeline into fix-publish-workflow
…stance as an optional parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements @Vicbi; looks great and happy to see this merged 🚀
Fix syntax error in version check command
♻️ Current situation & Problem
This PR addresses the syntax error in the Check if version already exists on PyPI/Test PyPI step of the GitHub Actions workflow. The
curl
andjq
command is now properly formatted and broken into multiple lines for better readability.⚙️ Release Notes
Corrected syntax and broke the
curl
andjq
command into multiple lines in the Check if version already exists on PyPI/Test PyPI step.📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: