-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow data access from full Firebase path #22
base: main
Are you sure you want to change the base?
Conversation
…dated documentation
…DataPipeline into fix-publish-workflow
…stance as an optional parameter
Added date filter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 82.87% 82.04% -0.83%
==========================================
Files 16 16
Lines 1582 1609 +27
==========================================
+ Hits 1311 1320 +9
- Misses 271 289 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Thank you for reviewing the PR @Vicbi! I have updated the |
I noticed that "effectivePeriod.start" is not consistent across different FHIR resource types so I added a |
@AdritRao thank you for the PR; I asked @vishnuravi to take a look at it while @Vicbi is on vacation; we already discussed some changes like moving the arguments in a separate type that contains the filter configuration to address the lint issues. We should ensure that we can make this well applicable for the future extension of the package. |
Hi @AdritRao, thank you for the code updates! :) Did you have the chance to review and set up the commit signing? It might also make sense to fix any lint issues before proceeding with any further modifications. |
Allow data access from full Firebase path
♻️ Current situation & Problem
Currently,
fetch_data
can only access data using a specified collection and subcollection. In some use cases, a user's HealthKit or survey data may be deeper in the database structure. Allowing developers to specify a full Firebase path can allow them to run access/flattening in any part of the database.Data can currently be sorted by date after being fetched. Adding a query filter (through Firebase indexing) can allow for sorting data before it is streamed and reduce time required to fetch data.
⚙️ Release Notes
fetch_data_path
function that takes in a full string database path (full_path
)subject_id
optional for_fetch_user_resources
and flattener to allow single user data access throughfetch_data_path
start_date
andend_date
parameter to run query filter infetch_data_path
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: