Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 6 language mode readiness and bump dependencies #23

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Dec 2, 2024

Swift 6 language mode readiness and bump dependencies

♻️ Current situation & Problem

As the repo wasn't properly maintained for quite some months, most dependencies have been severely outdated.

⚙️ Release Notes

  • Swift 6 language mode readiness
  • Bump dependencies to the newest versions

📚 Documentation

--

✅ Testing

Tested locally and UI tests passing

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Dec 2, 2024
@philippzagar philippzagar self-assigned this Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 40.68%. Comparing base (8a705dd) to head (8720b9f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...peziFHIRMockPatients/FHIRBundle+MockPatients.swift 40.00% 24 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #23       +/-   ##
===========================================
+ Coverage   28.61%   40.68%   +12.08%     
===========================================
  Files          36       20       -16     
  Lines        2031     1207      -824     
===========================================
- Hits          581      491       -90     
+ Misses       1450      716      -734     
Files with missing lines Coverage Δ
Sources/SpeziFHIR/FHIRStore.swift 89.53% <ø> (ø)
...peziFHIRMockPatients/FHIRBundle+MockPatients.swift 43.25% <40.00%> (-0.82%) ⬇️

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a705dd...8720b9f. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @philippzagar!

@philippzagar philippzagar changed the title Bump dependencies Swift 6 language mode readiness and bump dependencies Dec 3, 2024
@philippzagar
Copy link
Member Author

@PSchmiedmayer Extended the PR a bit to lift SpeziFHIR to Swift 6 language mode, making it more future proof.

@philippzagar philippzagar merged commit d368a1e into main Dec 3, 2024
8 checks passed
@philippzagar philippzagar deleted the feat/lift-dependencies branch December 3, 2024 10:37
@philippzagar philippzagar mentioned this pull request Dec 3, 2024
1 task
LeonNissen pushed a commit to StanfordBDHG/LLMonFHIR that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants