Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General fixes to stability. #219

Merged
merged 1 commit into from
Aug 18, 2022
Merged

General fixes to stability. #219

merged 1 commit into from
Aug 18, 2022

Conversation

StarArawn
Copy link
Owner

No description provided.

Copy link
Contributor

@mbolt35 mbolt35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have resolved the reduced frame rate! There does seem to be a small leak that occurs, but's not nearly as significant as before.

Any of the procedurally generated tilemaps I had just required adding the:

commands.entity(tile_map_entity).add_child(tile_entity)

during generation.

I haven't explored the performance implications much, but is there a way to batch add children?

From a usability standpoint, this definitely seems easy to get tripped up on, but it's somewhat unclear how to best include the add_child as part of the tilemap API.

Thank you for tracking this down, I'll keep my eye out on those bevy PRs as well.

@StarArawn
Copy link
Owner Author

StarArawn commented Aug 16, 2022

I haven't explored the performance implications much, but is there a way to batch add children?

Not yet, but I think we can add this. 👍

@StarArawn StarArawn merged commit ceeaaee into main Aug 18, 2022
@StarArawn StarArawn deleted the fixes branch August 18, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants