-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples cleanup #356
Examples cleanup #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a welcome standardization fix. Thanks for taking the time to do it.
My main question is around the removal of map_transform in the multiplication with the tile center's transform. Can you comment?
Note: there is currently (perhaps a) system ordering issue in edit: documented that here: #362 |
@rparrett Is this ready for review again? Also the conflicts need to be fixed. |
The default is 1280x720 which is very close to the old value.
It seems extremely unlikely that anyone would trip on this, but this is easy enough to fix...
33b52f5
to
df3ec71
Compare
Rebased. Looks like there's consensus on removing tile labels from bevy's hierarchy. I should be able to get that done later today. |
I feel like there is a lot left to do here, but this branch is getting large and I'm running out of time.
I tested all examples and their keyboard functionality.
texture_vec
texture_container
were already broken and the problem wasn't obvious so I didn't touch them.My main goal was to center a bunch of tilemaps and improve consistency of tilemap spawning code between examples, but I stumbled on a few other little cleanups.
I'd recommend reviewing individual commits.