Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive FromReflect for TileTextureIndex and more #434

Merged
merged 2 commits into from
Jun 11, 2023

Conversation

Carnagion
Copy link
Contributor

@Carnagion Carnagion commented Jun 8, 2023

Pretty self-explanatory.

I required TileTextureIndex to implement FromReflect, as I was using it with bevy_proto, which requires it for turning components into Schematics.

While I was at it, I also derived FromReflect for other types that implemented Component and Reflect, since it makes sense for most components on entities to be reflectable.

@Carnagion Carnagion changed the title Derive FromReflect for TileTextureIndex Derive FromReflect for TileTextureIndex and more Jun 8, 2023
Copy link
Owner

@StarArawn StarArawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good assuming CI passes. 👍

@StarArawn StarArawn merged commit 1bdc8d3 into StarArawn:main Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants