Implement From<TilePos> for CubePos
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piturnah
force-pushed
the
feat/impl-from
branch
from
8c76e00 to
ac731f2
Compare
StarArawn
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds an API converting directly from a
TilePosto aCubePoswithout having to go through an intermediateAxialPos. Because of the inline the codegen should be well optimised I think. This makes trait bounds better specifically (i.e. if I want a function takingP: Into<CubePos>then I can pass aTilePoswithout callingAxialPos::from).I didn't add the borrow version (
From<&TilePos>) as I saw a lot of the other structs had because I'm not really sure what it is for. If you want me to add it then let me know