Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more serde support #518

Merged
merged 3 commits into from
Mar 2, 2024
Merged

Added more serde support #518

merged 3 commits into from
Mar 2, 2024

Conversation

StarArawn
Copy link
Owner

No description provided.

@StarArawn StarArawn requested a review from rparrett March 2, 2024 03:06
rparrett
rparrett approved these changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@rparrett rparrett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find Bevy's serde / reflect-serialize stuff quite confusing and don't really have any way of testing but I don't see anything wrong.

src/tiles/mod.rs Outdated Show resolved Hide resolved
@StarArawn StarArawn merged commit 1e345d1 into main Mar 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StarArawn @rparrett