Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DependencyConstraints Caching to Use Last Modified Time #29

Closed
romeara opened this issue Sep 13, 2019 · 0 comments
Closed

Fix DependencyConstraints Caching to Use Last Modified Time #29

romeara opened this issue Sep 13, 2019 · 0 comments
Assignees
@romeara
Labels
bug Something isn't working release scope: micro Changes required for the issue are appropriate for a semantically "micro" release
Milestone
0.2.1

Comments

@romeara
Copy link
Member

romeara commented Sep 13, 2019

Currently, the caching in DependencyConstraints is based on last access time - a value that changes due to operations performed within DependencyConstraints itself.

It would make more sense to use last modified time in this context
@romeara romeara added the bug Something isn't working label Sep 13, 2019
@romeara romeara self-assigned this Sep 13, 2019
@romeara romeara added this to the next-release (micro) milestone Sep 13, 2019
@romeara romeara added the release scope: micro Changes required for the issue are appropriate for a semantically "micro" release label Sep 14, 2019
romeara added a commit that referenced this issue Sep 15, 2019
@romeara
Merge pull request #30 from StarChart-Labs/bugfix/romeara/29-cache-key
2883a67 
Resolves GH-29: Fixes issue with constraint file cache key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romeara romeara

Labels
bug Something isn't working release scope: micro Changes required for the issue are appropriate for a semantically "micro" release
Projects
None yet
Milestone
0.2.1
Development

No branches or pull requests
1 participant
@romeara