Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Optional Credentials #35

Closed
romeara opened this issue Sep 25, 2019 · 1 comment
Closed

Allow Optional Credentials #35

romeara opened this issue Sep 25, 2019 · 1 comment
Assignees
@romeara
Labels
enhancement New feature or request release scope: major Changes required for the issue are appropriate for a semantically "major" release
Milestone
1.0.0

Comments

@romeara
Copy link
Member

romeara commented Sep 25, 2019

Currently, credential sets fail if referenced and not present. This can be an issue for configuration DSLs for third-party plug-ins which resist configuration at runtime for tasks (such as the bintray plug-in)

It would be useful to allow getting the credential OR a default, so regular builds cna run without the values set, and only the build steps which require valid values fail if unset
@romeara romeara added enhancement New feature or request release scope: minor Changes required for the issue are appropriate for a semantically "minor" release labels Sep 25, 2019
@romeara
Copy link
Member Author

romeara commented Sep 25, 2019

Thinking about this more, optional may not be appropriate - the DSL already allows fallback (including to hard-coded, which could act as default). What should change is that the multi-module-library plug-in should default to something like "invalid-invalid" or similar.

This would be a non-backwards-compatible change in behavior

@romeara romeara added release scope: major Changes required for the issue are appropriate for a semantically "major" release and removed release scope: minor Changes required for the issue are appropriate for a semantically "minor" release labels Sep 25, 2019
@romeara romeara self-assigned this Oct 1, 2019
@romeara romeara added this to the next-release (major) milestone Oct 1, 2019
@romeara romeara closed this as completed in 061721b Oct 1, 2019
romeara added a commit that referenced this issue Oct 1, 2019
@romeara
Merge pull request #39 from StarChart-Labs/task/romeara/35-default-cr…
072452f 
…edentials

Resolves GH-35 Adds blank bintray credentials for non-publish runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romeara romeara

Labels
enhancement New feature or request release scope: major Changes required for the issue are appropriate for a semantically "major" release
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@romeara