Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-23 Fix issue where stale dependency cache could be used across builds #25

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

romeara
Copy link
Member

@romeara romeara commented Sep 13, 2019

Change caching logic for loaded dependency information to include time
modified, to prevent stale cached content from being used when changes
are made between builds. This situation could arise due to the Gradle
Daemon re-using class loaders between builds

Change caching logic for loaded dependency information to include time
modified, to prevent stale cached content from being used when changes
are made between builds. This situation could arise due to the Gradle
Daemon re-using class loaders between builds
@romeara romeara added the bug Something isn't working label Sep 13, 2019
@romeara romeara added this to the next-release milestone Sep 13, 2019
@romeara romeara requested a review from a team September 13, 2019 01:12
@romeara romeara self-assigned this Sep 13, 2019
@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #25 into master will decrease coverage by 0.37%.
The diff coverage is 80%.

@@             Coverage Diff              @@
##             master      #25      +/-   ##
============================================
- Coverage     85.04%   84.67%   -0.38%     
+ Complexity      252      251       -1     
============================================
  Files            25       25              
  Lines           749      757       +8     
  Branches         53       53              
============================================
+ Hits            637      641       +4     
- Misses           91       93       +2     
- Partials         21       23       +2
Impacted Files Coverage Δ Complexity Δ
...abs/flare/plugins/model/DependencyConstraints.java 86.11% <80%> (-6.75%) 10 <3> (ø)
...rchartlabs/flare/plugins/model/ConstraintFile.java 96.15% <0%> (-3.85%) 12% <0%> (-1%)

@blackduck-copilot
Copy link

blackduck-copilot bot commented Sep 13, 2019

Black Duck Security Report

Merging #25 into master will not change security risk.

Click here to see full report

Copy link
Member

@nickavv nickavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad that this is required but good solution

@romeara
Copy link
Member Author

romeara commented Sep 13, 2019

Yeah, am displeased with Gradle for necessitating it, but didn't want to reload dependencies in every project

@romeara romeara merged commit 7be078a into master Sep 13, 2019
@romeara romeara deleted the bugfix/romeara/23-prevent-stale-cache branch September 13, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants