Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves GH-15 Applies bintray credentials to JFrog-enabled builds only #46

Merged
merged 2 commits into from
Oct 3, 2019
Merged

Resolves GH-15 Applies bintray credentials to JFrog-enabled builds only #46

merged 2 commits into from
Oct 3, 2019

Conversation

romeara
Copy link
Member

@romeara romeara commented Oct 3, 2019

Changes the multi-module-library plug-in to only setup default bintray
credential conventions when the associated system (JFrog Bintray) has
had its plug-in applied to the build

@romeara
Resolves GH-15 Applies bintray credentials to JFrog-enabled builds only
c552b3f 
Changes the multi-module-library plug-in to only setup default bintray
credential conventions when the associated system (JFrog Bintray) has
had its plug-in applied to the build
@romeara romeara added enhancement New feature or request release scope: major Changes required for the issue are appropriate for a semantically "major" release labels Oct 3, 2019
@romeara romeara added this to the next-release (major) milestone Oct 3, 2019
@romeara romeara requested a review from a team October 3, 2019 01:57
@romeara romeara self-assigned this Oct 3, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019 •
edited
Loading

Codecov Report

Merging #46 into master will decrease coverage by 0.22%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
- Coverage     85.77%   85.54%   -0.23%     
  Complexity      254      254              
============================================
  Files            26       26              
  Lines           766      768       +2     
  Branches         53       53              
============================================
  Hits            657      657              
- Misses           85       87       +2     
  Partials         24       24
Impacted Files Coverage Δ Complexity Δ
...flare/plugins/plugin/MultiModuleLibraryPlugin.java 0% <0%> (ø) 0 <0> (ø) ⬇️

nickavv
nickavv approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@nickavv nickavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor typo looks good

@blackduck-copilot
Copy link

Black Duck Security Report

Merging #46 into master will not change security risk.

Click here to see full report

@romeara @nickavv
Correct typos in migration guide
f164b28 
Co-Authored-By: Nick Ver Voort <talkto@nicholasvv.com>
@romeara romeara merged commit 8babc70 into master Oct 3, 2019
@romeara romeara deleted the task/romeara/15-conditional-bintray-credentials branch October 3, 2019 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickavv nickavv nickavv approved these changes

Assignees

@romeara romeara

Labels
enhancement New feature or request release scope: major Changes required for the issue are appropriate for a semantically "major" release
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@romeara @nickavv