Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix partial update column name sensitive issue (backport #55430) #55441

Open
wants to merge 2 commits into
base: branch-3.4
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 26, 2025

Why I'm doing:

Fix partial update column name sensitive issue.

E.g:
table:

CREATE TABLE `test` (
  `id` bigint(20) NOT NULL COMMENT "",
  `name` varchar(16) NULL DEFAULT "" COMMENT "",
  `city` varchar(16) NULL DEFAULT "" COMMENT "",
  `age` varchar(24) NULL DEFAULT "" COMMENT ""
) ENGINE=OLAP
PRIMARY KEY(`id`)
DISTRIBUTED BY HASH(`id`) BUCKETS 1
PROPERTIES (
"replication_num" = "1"
); 

partial update:

curl --location-trusted -u root: -T tt.csv -XPUT -H label:stream_load_1 -H "partial_update:true" -H "columns:ID,name" -H "timeout:86400" -H "max_filter_ratio:0.1" http://172.26.80.4:8030/api/testdb/test2/_stream_load

Use columns:ID,name instead of columns:id,name. It will lead to:

"Message": "key column id not in partial update columns",

What I'm doing:

Fix it

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit ab228aa)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/Load.java
@mergify mergify bot added the conflicts label Jan 26, 2025
Copy link
Contributor Author

mergify bot commented Jan 26, 2025

Cherry-pick of ab228aa has failed:

On branch mergify/bp/branch-3.4/pr-55430
Your branch is up to date with 'origin/branch-3.4'.

You are currently cherry-picking commit ab228aaac.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   test/common/data/stream_load/test_partial_update_case_sensitive.csv
	new file:   test/sql/test_stream_load/R/test_partial_update_case_sensitive
	new file:   test/sql/test_stream_load/T/test_partial_update_case_sensitive

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/load/Load.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 26, 2025 02:57
@mergify mergify bot closed this Jan 26, 2025
auto-merge was automatically disabled January 26, 2025 02:57

Pull request was closed

Copy link
Contributor Author

mergify bot commented Jan 26, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@luohaha luohaha reopened this Jan 26, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 26, 2025 03:04
Signed-off-by: Yixin Luo <18810541851@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant