Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]delete old way to deal with metadata in parquet reader #55451

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Jan 26, 2025

Why I'm doing:

As we have a new way to deal with metadata and predicates,
I'd like to remove the code of old version.
So there are two ways in 3.4 and use new way as default.
And there will be only the new way in 3.5.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0 zombee0 force-pushed the remove_old_metadealer branch from f2682ef to af77af4 Compare January 26, 2025 07:32
Signed-off-by: zombee0 <ewang2027@gmail.com>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 45 / 46 (97.83%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/formats/parquet/group_reader.cpp 8 9 88.89% [88]
🔵 be/src/formats/parquet/file_reader.cpp 9 9 100.00% []
🔵 be/src/formats/parquet/column_reader.cpp 8 8 100.00% []
🔵 be/src/exec/hdfs_scanner.cpp 17 17 100.00% []
🔵 be/src/formats/parquet/column_reader.h 3 3 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant