-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the event-based trigger of dirty checking outside of JSON-Patch #99
Comments
warpech
changed the title
Move the response of dirty checking outside of JSON-Patch
Move the event-based trigger of dirty checking outside of JSON-Patch
Apr 21, 2016
In a nutshell it means move The beauty of it is that it can be done in steps:
|
LGTM :) Maybe, we could also provide tiny library/snippet (as a migration helper) for those who currently use |
Plan for development:
|
Assigning to @aloscha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In spirit of #88 (comment), I think that the best way to trigger dirty checking would be to actually move it out of JSON-Patch.
In our use case, it should be moved to https://github.com/PuppetJs/PuppetJs/blob/gh-pages/src/puppet-dom.js.
The code in Puppet DOM will trigger
jsonpatch.generate(puppet.observer)
from the outside on certain DOM events (mouseup
,keyup
). There will be only single call (setTimeout0
), instead of current interval calls.This could be celebrated by giving it a 1.0.0 number (#80)
@tomalec, @miyconst WDYT?
The text was updated successfully, but these errors were encountered: