Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe callback only in a minute #88

Closed
ghost opened this issue Dec 15, 2015 · 4 comments
Closed

Observe callback only in a minute #88

ghost opened this issue Dec 15, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented Dec 15, 2015

Hi,

Object.observe() is not used any more, which is incorrectly stated in Features list. And due to this the previously working instant notification about any change in the object is gone. Not sure that checking changes in regular intervals is efficient. Any plans to improve on this one?

Cheers

@tomalec
Copy link
Collaborator

tomalec commented Jan 13, 2016

Thanks for reporting it :)
@miyconst could you remove O.o from the readme, and comments if any?
@warpech WDYT? Do you have any ideas on how to mimic previous behavior better?Plus, we could expose some API to configure and flush those intervals

@miyconst
Copy link
Collaborator

Sure, I can do that.

@miyconst miyconst self-assigned this Jan 13, 2016
miyconst pushed a commit that referenced this issue Jan 14, 2016
@miyconst miyconst removed their assignment Jan 14, 2016
@warpech
Copy link
Collaborator

warpech commented Jan 21, 2016

In future, we can switch to be using ES6 Proxy.

Right now I guess we should stick with dirty checking. I talked today with @Starcounter-Jack and indeed we think that it might be a good idea to remove time intervals at all.

@warpech
Copy link
Collaborator

warpech commented May 26, 2016

Long term plan: ES6 Proxy (#96)
Short term plan: Remove slowCheck (dirty checking in fixed time intervals) (#103)

@warpech warpech closed this as completed May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants