Change the behavior in case of undefined value
#107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit only changes the test to the proposed solution to treating undefineds.
I think that `jsonpatch.generate` should treat undefined exactly the same way it is treated in `json.stringify` and `jsonpatch.compare`.
Every test should go the following path:
var a = /*some object*/;
observe(a);
a.change = /*new value*/;
var patches1 = generate(a);
var b = (same object);
var c = clone(b);
b.change = /*new value*/
var patches2 = jsonpatch.compare(b, c);
expect(patches1).toReallyEqual(/*expected patch*/);
expect(patches1).toReallyEqual(patches2);
toReallyEqual is a wrapper around Underscore isEqual, which knows the difference between undefined, null and unset values.
|
|
||
| ~~However, to play nicer with natural JavaScipt objects `jsonpatch` can be applied to an object that contains `undefined`, in such case we will use it as native `JSON.stringify` - we will treat them as non-existing nodes, and map to `null` for array elements.~~ | ||
| Whenever a value is set to `undefined` in JS, JSON-Patch methods `generate` and `compare` will treat it similarly to how JavaScript method `JSON.stringify` treats them. See the test suite (in the `test/` subdirectory) or the [ECMAScript spec](http://www.ecma-international.org/ecma-262/6.0/index.html#sec-json.stringify) for details. |
There was a problem hiding this comment.
I'd link JSON.stringify to MDN or in exact spec and briefly describe what it does, like "treat as not specified"
|
@tomalec, all your comments reviewed and applied. Anything more to add? |
|
LGTM |
|
Done, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issues #105, #90, #60, #32 and a part of #76 that describes a problem with undefined
all tests pass after this commit