Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event handling improvements #229

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Event handling improvements #229

merged 2 commits into from
Jul 9, 2019

Conversation

warpech
Copy link
Collaborator

@warpech warpech commented Jul 2, 2019

  1. Remove support for IE<11 which was redundant since https://github.com/Starcounter-Jack/JSON-Patch/releases/tag/v2.0.7
  2. Fix removal of event handlers

warpech added 2 commits July 2, 2019 12:25
because this was a memory leak at least.
also, added tests for removal of any event listeners
@warpech warpech requested a review from tomalec July 2, 2019 10:44
Copy link
Collaborator

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants