Skip to content

[pull] main from emscripten-core:main#118

Merged
pull[bot] merged 1 commit intoStars1233:mainfrom
emscripten-core:main
Jul 3, 2025
Merged

[pull] main from emscripten-core:main#118
pull[bot] merged 1 commit intoStars1233:mainfrom
emscripten-core:main

Conversation

@pull
Copy link

@pull pull bot commented Jul 3, 2025 •
edited by sourcery-ai bot
Loading

See Commits and Changes for more details.

Created by pull[bot] (v2.0.0-alpha.2)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Register pthread TLS initialization earlier in the minimal runtime postamble and introduce a new C _Thread_local pthread test.

Enhancements:

  • Move PThread.tlsInitFunctions.push call before the pthread environment check in postamble_minimal.js to ensure thread-local initialization is always registered in minimal builds

Tests:

  • Add test_pthread_c_thread_local.cpp C test and corresponding expected output to verify C11 _Thread_local storage behavior with pthreads
  • Integrate the new C thread-local test into test_core.py with node and minimal runtime decorators and skip conditions for ASan

@brendandahl
[pthreads] Initialize TLS on workers in MINIMAL_RUNTIME mode. (#24646)
b0c461c 
TLS was not initialized on workers causing the tls_base address to be 0
and write to the wrong memory location.

Fixes #21528 and is also needed for PR #24565
@pull pull bot locked and limited conversation to collaborators Jul 3, 2025
@pull pull bot added the ⤵️ pull label Jul 3, 2025
@pull pull bot merged commit b0c461c into Stars1233:main Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

⤵️ pull

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@brendandahl