Fix user directory access #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stary2001
force-pushed
the
3.3-stable_switch
branch
from
06c523b to
d5f52f6
Compare
|
This seems fine, though I'd prefer a better fallback in the app_name=="" case (get_resource_dir() is empty except on Android). |
I copied this fallback from the OSWindows implementation, what do you suggest we do instead? fallback to sdmc:/switch/godot/__unknown or something like that? |
|
Yeah, that sounds reasonable. |
EIREXE
force-pushed
the
fix_user_dir_access
branch
from
692de70 to
d89e069
Compare
EIREXE
force-pushed
the
fix_user_dir_access
branch
from
d89e069 to
3c2cbda
Compare
I think this should be it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.