Tabulator #182
Open
Tabulator #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Lib/StatCan.OrchardCore.Application.Targets/StatCan.OrchardCore.Application.Targets.csproj
M-A-Boucher
requested changes
Feb 1, 2021
src/Modules/StatCan.OrchardCore.Assessment/Views/Widget-Assessment.liquid
Outdated
Show resolved
Hide resolved
| @@ -15,15 +15,18 @@ | |||
| <ProjectReference Include="..\StatCan.OrchardCore.Security\StatCan.OrchardCore.Security.csproj" PrivateAssets="none" /> | |||
|
|
|||
| <!-- Modules --> | |||
| <ProjectReference Include="..\..\Modules\StatCan.OrchardCore.Assessment\StatCan.OrchardCore.Assessment.csproj" PrivateAssets="none" /> | |||
There was a problem hiding this comment.
This line of code is from another branch and can be removed.
M-A-Boucher
requested changes
Feb 1, 2021
| @@ -7,7 +7,10 @@ | |||
|
|
|||
There was a problem hiding this comment.
Layout.liquid can be deleted. These are base templates for a theme and they're not needed for a module.
src/Lib/StatCan.OrchardCore.Application.Targets/StatCan.OrchardCore.Application.Targets.csproj
Outdated
Show resolved
Hide resolved
| "DisplayName": "TableCreator", | ||
| "Settings": { | ||
| "ContentTypeSettings": { | ||
| "Creatable": true, |
There was a problem hiding this comment.
Widgets usually have the following settings set to false: Creatable, Listable, Draftable, Versionable, Securable. Simply change them to false.
jptissot
reviewed
Feb 1, 2021
|
|
||
| public int Create() | ||
| { | ||
| return 1; |
There was a problem hiding this comment.
Is this required ? It is not doing anything
jptissot
added
the
wait-to-merge
|
I edited the initial post to link the issue. Let's review the issue and see what we can come up with as to requirements for the issue. |
M-A-Boucher
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #177